From 82b0de92d5dee92f2560aa62cce2835ab01b486e Mon Sep 17 00:00:00 2001
From: finalerock44 <ethan@devicecloud.dev>
Date: Wed, 11 Nov 2026 12:34:55 +0000
Subject: [PATCH] docs: OpenAPI spec, download 404 uses the standard error
 envelope

POST /results/{uploadId}/download now throws its unknown-upload 404 for the
API's exception filter (dcd fix/download-404-envelope), so the body is
{ statusCode: 404, message, error: 'Not Found' } rather than { message }.
The JUnit and HTML report downloads still answer { message }.
---
 public/openapi.yaml | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)

diff --git a/public/openapi.yaml b/public/openapi.yaml
index 265ccca..19f48cc 100644
--- a/public/openapi.yaml
+++ b/public/openapi.yaml
@@ -483,7 +483,17 @@ paths:
         '403':
           $ref: '#/components/responses/Forbidden'
         '404':
-          $ref: '#/components/responses/NoResults'
+          description: |
+            The upload has no results in your organization, or doesn't exist. Unlike
+            the report downloads, this one answers with the standard error envelope.
+          content:
+            application/json:
+              schema:
+                $ref: '#/components/schemas/ErrorEnvelope'
+              example:
+                statusCode: 404
+                message: No results found for this upload
+                error: Not Found
         '429':
           $ref: '#/components/responses/RateLimited'
         '503':
@@ -3253,7 +3263,7 @@ components:
           type: string
     MessageOnlyError:
       type: object
-      description: The error body of the report and artifact downloads.
+      description: The error body of the JUnit and HTML report downloads.
       required: [message]
       properties:
         message: