From 3a9db6024a0e03bdb101270d87f2b2f5c6b483b7 Mon Sep 17 00:00:00 2001 From: sushaan-k Date: Sun, 17 May 2026 23:16:55 -0400 Subject: [PATCH] test: replace duplicate datasets test with actual dataset coverage The previous clients/ts-sdk/src/functions/datasets/datasets.test.ts was a verbatim copy of events.test.ts (same describe("Events Tests") block, same getEventsForDataset call), so the datasets module had zero coverage. This rewrites the file to test the datasets module. The selected calls are read-only (no datasets created, modified, or deleted), so the suite is safe to run repeatedly against the shared sandbox dataset that backs the other ts-sdk integration tests. Coverage added: - getDatasetById - getDatasetUsageById - getDatasetsFromOrganization - getAllDatasetTags - getDatasetQueueLengths --- .../src/functions/datasets/datasets.test.ts | 43 ++++++++++++++++--- 1 file changed, 38 insertions(+), 5 deletions(-) diff --git a/clients/ts-sdk/src/functions/datasets/datasets.test.ts b/clients/ts-sdk/src/functions/datasets/datasets.test.ts index f9e2d7d213..bdb67eb443 100644 --- a/clients/ts-sdk/src/functions/datasets/datasets.test.ts +++ b/clients/ts-sdk/src/functions/datasets/datasets.test.ts @@ -1,17 +1,50 @@ import { beforeAll, describe, expectTypeOf } from "vitest"; import { TrieveSDK } from "../../sdk"; -import { EventReturn } from "../../types.gen"; +import { + Dataset, + DatasetAndUsage, + DatasetQueueLengthsResponse, + DatasetUsageCount, + GetAllTagsResponse, +} from "../../types.gen"; import { TRIEVE } from "../../__tests__/constants"; import { test } from "../../__tests__/utils"; -describe("Events Tests", async () => { +describe("Dataset Tests", async () => { let trieve: TrieveSDK; beforeAll(() => { trieve = TRIEVE; }); - test("getEventsForDataset", async () => { - const data = await trieve.getEventsForDataset({}); - expectTypeOf(data).toEqualTypeOf(); + test("getDatasetById", async () => { + const data = await trieve.getDatasetById(trieve.datasetId!); + expectTypeOf(data).toEqualTypeOf(); + }); + + test("getDatasetUsageById", async () => { + const data = await trieve.getDatasetUsageById(trieve.datasetId!); + expectTypeOf(data).toEqualTypeOf(); + }); + + test("getDatasetsFromOrganization", async () => { + const data = await trieve.getDatasetsFromOrganization( + trieve.organizationId!, + ); + expectTypeOf(data).toEqualTypeOf(); + }); + + test("getAllDatasetTags", async () => { + const data = await trieve.getAllDatasetTags( + { + page: 1, + }, + trieve.datasetId!, + ); + expectTypeOf(data).toEqualTypeOf(); + }); + + test("getDatasetQueueLengths", async () => { + const data = await trieve.getDatasetQueueLengths(trieve.datasetId!); + expectTypeOf(data).toEqualTypeOf(); }); });