Skip to content

Fix certificate verification for Ubuntu 24.04/Debian Trixie in docker features#1577

Open
abdurriq wants to merge 1 commit intodevcontainers:mainfrom
abdurriq:abdurriq/dind-cert-fix
Open

Fix certificate verification for Ubuntu 24.04/Debian Trixie in docker features#1577
abdurriq wants to merge 1 commit intodevcontainers:mainfrom
abdurriq:abdurriq/dind-cert-fix

Conversation

@abdurriq
Copy link
Contributor

Certificates aren't up-to-date in base image, so this runs a certificate update which fixes validation issues.

Original PR (merged into another feature branch): #1569

… features (devcontainers#1569)

* Initial plan

* Add update-ca-certificates call after installing ca-certificates package

Co-authored-by: abdurriq <137001048+abdurriq@users.noreply.github.com>

* Bump feature versions: docker-outside-of-docker to 1.8.0, docker-in-docker to 2.16.0

Co-authored-by: abdurriq <137001048+abdurriq@users.noreply.github.com>

* Add error handling and documentation for update-ca-certificates calls

Co-authored-by: abdurriq <137001048+abdurriq@users.noreply.github.com>

* Remove invalid test for docker-compose when v2 isn't installed

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: abdurriq <137001048+abdurriq@users.noreply.github.com>
Co-authored-by: Abdurrahmaan Iqbal <abdurriq@github.com>
@abdurriq abdurriq requested a review from a team as a code owner February 17, 2026 12:35
Copy link

@sam-byng sam-byng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version bump + certificate update LGTM!
Is there a test plan of this before rollout?

"default": false,
"description": "Disable ip6tables (this option is only applicable for Docker versions 27 and greater)"
}
"id": "docker-in-docker",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: whitespace has changed from 4-> 2 spaces or something. So the diff is odd

"default": true,
"description": "Install Compose Switch (provided docker compose is available) which is a replacement to the Compose V1 docker-compose (python) executable. It translates the command line into Compose V2 docker compose then runs the latter."
}
"id": "docker-outside-of-docker",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: whitespace change makes this hard to review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments