Skip to content

Commit 82f1c38

Browse files
ai: apply changes for #1005 (1 review thread)
Addresses: - #4418281963 at src/databricks/sql/result_set.py:143 Signed-off-by: peco-engineer-bot[bot] <peco-engineer-bot[bot]@users.noreply.github.com>
1 parent ea59ba7 commit 82f1c38

1 file changed

Lines changed: 6 additions & 2 deletions

File tree

‎src/databricks/sql/result_set.py‎

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -141,8 +141,12 @@ def _convert_arrow_table(self, table):
141141
column = table.column(col_idx)
142142
if not pyarrow.types.is_floating(column.type):
143143
continue
144-
nan_mask = pc.fill_null(pc.is_nan(column), False)
145-
res[nan_mask.to_numpy(), col_idx] = float("nan")
144+
nan_mask = pc.is_nan(column)
145+
# Cheap early-out: most float columns contain no NaN. pc.any skips
146+
# nulls, so all-null/empty columns yield None and are skipped too.
147+
if not pc.any(nan_mask).as_py():
148+
continue
149+
res[pc.fill_null(nan_mask, False).to_numpy(), col_idx] = float("nan")
146150

147151
return [ResultRow(*v) for v in res]
148152

0 commit comments

Comments
 (0)