From c624c206b0b5c9d1ed214c663a60d859cf9fdb06 Mon Sep 17 00:00:00 2001 From: chrchr-github <78114321+chrchr-github@users.noreply.github.com> Date: Thu, 9 Apr 2026 09:07:23 +0200 Subject: [PATCH 1/3] Avoid knownConditionTrueFalse warning in signalhandler.cpp --- cli/signalhandler.cpp | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/cli/signalhandler.cpp b/cli/signalhandler.cpp index f8fd5a4e0a0..c5416bb1d00 100644 --- a/cli/signalhandler.cpp +++ b/cli/signalhandler.cpp @@ -108,14 +108,15 @@ static const Signalmap_t listofsignals = { */ static void CppcheckSignalHandler(int signo, siginfo_t * info, void * context) // cppcheck-suppress constParameterCallback - info can be const { - int type = -1; + const char* typeStr = ""; pid_t killid; // TODO: separate these two defines #if defined(__linux__) && defined(REG_ERR) const auto* const uc = reinterpret_cast(context); killid = static_cast(syscall(SYS_gettid)); if (uc) { - type = static_cast(uc->uc_mcontext.gregs[REG_ERR]) & 2; + const int type = static_cast(uc->uc_mcontext.gregs[REG_ERR]) & 2; + typeStr = (type == 0) ? "reading " : "writing ", } #else (void)context; @@ -258,9 +259,7 @@ static void CppcheckSignalHandler(int signo, siginfo_t * info, void * context) / break; } fprintf(output, " (%sat 0x%lx).%s\n", - // cppcheck-suppress knownConditionTrueFalse ; FP - (type==-1)? "" : - (type==0) ? "reading " : "writing ", + typeStr reinterpret_cast(info->si_addr), isAddressOnStack ? " Stackoverflow?" : "" ); From d934a08289e15a377d2c034dd7725a49236beb25 Mon Sep 17 00:00:00 2001 From: chrchr-github <78114321+chrchr-github@users.noreply.github.com> Date: Thu, 9 Apr 2026 10:03:19 +0200 Subject: [PATCH 2/3] Update signalhandler.cpp --- cli/signalhandler.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cli/signalhandler.cpp b/cli/signalhandler.cpp index c5416bb1d00..99868574ff8 100644 --- a/cli/signalhandler.cpp +++ b/cli/signalhandler.cpp @@ -259,7 +259,7 @@ static void CppcheckSignalHandler(int signo, siginfo_t * info, void * context) / break; } fprintf(output, " (%sat 0x%lx).%s\n", - typeStr + typeStr, reinterpret_cast(info->si_addr), isAddressOnStack ? " Stackoverflow?" : "" ); From 46d7bb37f663d8cd0ad0b4cd89a181477712f396 Mon Sep 17 00:00:00 2001 From: chrchr-github <78114321+chrchr-github@users.noreply.github.com> Date: Thu, 9 Apr 2026 10:34:43 +0200 Subject: [PATCH 3/3] Update signalhandler.cpp --- cli/signalhandler.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cli/signalhandler.cpp b/cli/signalhandler.cpp index 99868574ff8..64e5038e82e 100644 --- a/cli/signalhandler.cpp +++ b/cli/signalhandler.cpp @@ -116,7 +116,7 @@ static void CppcheckSignalHandler(int signo, siginfo_t * info, void * context) / killid = static_cast(syscall(SYS_gettid)); if (uc) { const int type = static_cast(uc->uc_mcontext.gregs[REG_ERR]) & 2; - typeStr = (type == 0) ? "reading " : "writing ", + typeStr = (type == 0) ? "reading " : "writing "; } #else (void)context;