fix: Centralize EF Core provider names and improve executor config

Introduce ProviderName class to centralize EF Core provider name constants, replacing scattered string literals and private constants. Update all provider selection logic to use these constants. Refactor OutboxOperationsExecutor constructors to accept maxDegreeOfParallelism for improved concurrency control. Enhance maintainability and reduce errors in provider-specific logic.

Author: samtrion

src/NetEvolve.Pulse.EntityFramework/ModelBuilderExtensions.cs

@@ -12,37 +12,6 @@
 /// </summary>
 public static class ModelBuilderExtensions
 {
-    /// <summary>
-    /// The provider name for the EF Core InMemory provider (<c>Microsoft.EntityFrameworkCore.InMemory</c>).
-    /// Intended for testing only.
-    /// </summary>
-    private const string InMemoryProviderName = "Microsoft.EntityFrameworkCore.InMemory";
-
-    /// <summary>
-    /// The provider name for Npgsql (PostgreSQL).
-    /// </summary>
-    private const string NpgsqlProviderName = "Npgsql.EntityFrameworkCore.PostgreSQL";
-
-    /// <summary>
-    /// The provider name for Microsoft.EntityFrameworkCore.Sqlite.
-    /// </summary>
-    private const string SqliteProviderName = "Microsoft.EntityFrameworkCore.Sqlite";
-
-    /// <summary>
-    /// The provider name for Microsoft.EntityFrameworkCore.SqlServer.
-    /// </summary>
-    private const string SqlServerProviderName = "Microsoft.EntityFrameworkCore.SqlServer";
-
-    /// <summary>
-    /// The provider name for Pomelo MySQL (<c>Pomelo.EntityFrameworkCore.MySql</c>).
-    /// </summary>
-    private const string PomeloMySqlProviderName = "Pomelo.EntityFrameworkCore.MySql";
-
-    /// <summary>
-    /// The provider name for the Oracle MySQL provider (<c>MySql.EntityFrameworkCore</c>).
-    /// </summary>
-    private const string OracleMySqlProviderName = "MySql.EntityFrameworkCore";
-
     /// <summary>
     /// Applies all Pulse-related entity configurations to the model builder.
     /// </summary>
@@ -98,11 +67,13 @@ private static IEntityTypeConfiguration<OutboxMessage> GetOutboxConfiguration<TC
         resolvedOptions ??= Options.Create(new OutboxOptions());
         return providerName switch
         {
-            NpgsqlProviderName => new PostgreSqlOutboxMessageConfiguration(resolvedOptions),
-            SqliteProviderName => new SqliteOutboxMessageConfiguration(resolvedOptions),
-            SqlServerProviderName => new SqlServerOutboxMessageConfiguration(resolvedOptions),
-            PomeloMySqlProviderName or OracleMySqlProviderName => new MySqlOutboxMessageConfiguration(resolvedOptions),
-            InMemoryProviderName => new InMemoryOutboxMessageConfiguration(resolvedOptions),
+            ProviderName.Npgsql => new PostgreSqlOutboxMessageConfiguration(resolvedOptions),
+            ProviderName.Sqlite => new SqliteOutboxMessageConfiguration(resolvedOptions),
+            ProviderName.SqlServer => new SqlServerOutboxMessageConfiguration(resolvedOptions),
+            ProviderName.PomeloMySql or ProviderName.OracleMySql => new MySqlOutboxMessageConfiguration(
+                resolvedOptions
+            ),
+            ProviderName.InMemory => new InMemoryOutboxMessageConfiguration(resolvedOptions),
             _ => throw new NotSupportedException($"Unsupported EF Core provider: {providerName}"),
         };
     }

src/NetEvolve.Pulse.EntityFramework/Outbox/BulkOutboxOperationsExecutor.cs

@@ -13,10 +13,11 @@ namespace NetEvolve.Pulse.Outbox;
 /// (SQL Server, PostgreSQL, SQLite, and others).
 /// </remarks>
 /// <typeparam name="TContext">The DbContext type that implements <see cref="IOutboxDbContext"/>.</typeparam>
-internal sealed class BulkOutboxOperationsExecutor<TContext>(TContext context) : IOutboxOperationsExecutor
+internal sealed class BulkOutboxOperationsExecutor<TContext>(TContext context, int maxDegreeOfParallelism)
+    : IOutboxOperationsExecutor
     where TContext : DbContext, IOutboxDbContext
 {
-    private readonly SemaphoreSlim _semaphore = new(1, 1);
+    private readonly SemaphoreSlim _semaphore = new(maxDegreeOfParallelism, maxDegreeOfParallelism);
     private bool _disposedValue;
 
     /// <inheritdoc />

src/NetEvolve.Pulse.EntityFramework/Outbox/EntityFrameworkOutboxRepository.cs

@@ -47,11 +47,12 @@ public EntityFrameworkOutboxRepository(TContext context, TimeProvider timeProvid
         _executor = context.Database.ProviderName switch
         {
             // InMemory does not support ExecuteUpdate/ExecuteDelete at all.
-            "Microsoft.EntityFrameworkCore.InMemory" => new InMemoryOutboxOperationsExecutor<TContext>(context),
+            ProviderName.InMemory => new InMemoryOutboxOperationsExecutor<TContext>(context, 1),
             // Oracle MySQL cannot apply value converters in ExecuteUpdateAsync parameters and
             // cannot translate a parameterised Guid collection into a SQL IN clause.
-            "MySql.EntityFrameworkCore" => new MySqlOutboxOperationsExecutor<TContext>(context),
-            _ => new BulkOutboxOperationsExecutor<TContext>(context),
+            ProviderName.OracleMySql => new MySqlOutboxOperationsExecutor<TContext>(context, 1),
+            ProviderName.Npgsql => new BulkOutboxOperationsExecutor<TContext>(context, 1),
+            _ => new BulkOutboxOperationsExecutor<TContext>(context, Environment.ProcessorCount - 1),
         };
     }
 

src/NetEvolve.Pulse.EntityFramework/Outbox/InMemoryOutboxOperationsExecutor.cs

@@ -14,8 +14,8 @@ namespace NetEvolve.Pulse.Outbox;
 /// <see cref="TrackingOutboxOperationsExecutorBase{TContext}"/>).
 /// </remarks>
 /// <typeparam name="TContext">The DbContext type that implements <see cref="IOutboxDbContext"/>.</typeparam>
-internal sealed class InMemoryOutboxOperationsExecutor<TContext>(TContext context)
-    : TrackingOutboxOperationsExecutorBase<TContext>(context)
+internal sealed class InMemoryOutboxOperationsExecutor<TContext>(TContext context, int maxDegreeOfParallelism)
+    : TrackingOutboxOperationsExecutorBase<TContext>(context, maxDegreeOfParallelism)
     where TContext : DbContext, IOutboxDbContext
 {
     /// <inheritdoc />

src/NetEvolve.Pulse.EntityFramework/Outbox/MySqlOutboxOperationsExecutor.cs

@@ -27,8 +27,8 @@ namespace NetEvolve.Pulse.Outbox;
 /// cache for entities already loaded by <c>FetchAndMarkAsync</c>.
 /// </remarks>
 /// <typeparam name="TContext">The DbContext type that implements <see cref="IOutboxDbContext"/>.</typeparam>
-internal sealed class MySqlOutboxOperationsExecutor<TContext>(TContext context)
-    : TrackingOutboxOperationsExecutorBase<TContext>(context)
+internal sealed class MySqlOutboxOperationsExecutor<TContext>(TContext context, int maxDegreeOfParallelism)
+    : TrackingOutboxOperationsExecutorBase<TContext>(context, maxDegreeOfParallelism)
     where TContext : DbContext, IOutboxDbContext
 {
     /// <inheritdoc />

src/NetEvolve.Pulse.EntityFramework/Outbox/TrackingOutboxOperationsExecutorBase.cs

@@ -14,13 +14,14 @@ namespace NetEvolve.Pulse.Outbox;
 /// Derived classes only need to implement <see cref="UpdateByIdsAsync"/>, which varies by provider.
 /// </remarks>
 /// <typeparam name="TContext">The DbContext type that implements <see cref="IOutboxDbContext"/>.</typeparam>
-internal abstract class TrackingOutboxOperationsExecutorBase<TContext>(TContext context) : IOutboxOperationsExecutor
+internal abstract class TrackingOutboxOperationsExecutorBase<TContext>(TContext context, int maxDegreeOfParallelism)
+    : IOutboxOperationsExecutor
     where TContext : DbContext, IOutboxDbContext
 {
     /// <summary>The DbContext used for all tracking-based query and update operations.</summary>
     protected readonly TContext _context = context;
 
-    protected readonly SemaphoreSlim _semaphore = new SemaphoreSlim(1, 1);
+    protected readonly SemaphoreSlim _semaphore = new SemaphoreSlim(maxDegreeOfParallelism, maxDegreeOfParallelism);
     private bool _disposedValue;
 
     /// <inheritdoc />

src/NetEvolve.Pulse.EntityFramework/ProviderName.cs

@@ -0,0 +1,38 @@
+namespace NetEvolve.Pulse;
+
+/// <summary>
+/// Static class containing constants for supported EF Core provider names, used for provider-specific
+/// </summary>
+internal static class ProviderName
+{
+    /// <summary>
+    /// The provider name for the EF Core InMemory provider (<c>Microsoft.EntityFrameworkCore.InMemory</c>).
+    /// Intended for testing only.
+    /// </summary>
+    internal const string InMemory = "Microsoft.EntityFrameworkCore.InMemory";
+
+    /// <summary>
+    /// The provider name for Npgsql (PostgreSQL).
+    /// </summary>
+    internal const string Npgsql = "Npgsql.EntityFrameworkCore.PostgreSQL";
+
+    /// <summary>
+    /// The provider name for Microsoft.EntityFrameworkCore.Sqlite.
+    /// </summary>
+    internal const string Sqlite = "Microsoft.EntityFrameworkCore.Sqlite";
+
+    /// <summary>
+    /// The provider name for Microsoft.EntityFrameworkCore.SqlServer.
+    /// </summary>
+    internal const string SqlServer = "Microsoft.EntityFrameworkCore.SqlServer";
+
+    /// <summary>
+    /// The provider name for Pomelo MySQL (<c>Pomelo.EntityFrameworkCore.MySql</c>).
+    /// </summary>
+    internal const string PomeloMySql = "Pomelo.EntityFrameworkCore.MySql";
+
+    /// <summary>
+    /// The provider name for the Oracle MySQL provider (<c>MySql.EntityFrameworkCore</c>).
+    /// </summary>
+    internal const string OracleMySql = "MySql.EntityFrameworkCore";
+}