From b3c2e75b8fc226b6cb2c5e3aaccc896ae1c54055 Mon Sep 17 00:00:00 2001 From: Tim Heap Date: Mon, 18 May 2026 17:12:15 +1000 Subject: [PATCH 1/4] Fix missing python-version warning from actions/setup-python We don't actually use the python from setup-python, we use the python from conda. The action complains bitterly if you don't give it a version though. --- .github/actions/environment/action.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/actions/environment/action.yaml b/.github/actions/environment/action.yaml index 5f75e90..8b683fe 100644 --- a/.github/actions/environment/action.yaml +++ b/.github/actions/environment/action.yaml @@ -31,6 +31,7 @@ runs: # Used for the pip cache, not for the python version - uses: actions/setup-python@v5 with: + python-version: ${{ inputs.python-version }} cache: 'pip' cache-dependency-path: | continuous-integration/requirements-${{ inputs.python-version }}.txt From 2988686d0f838a4ed30120dd97c83a349689c78d Mon Sep 17 00:00:00 2001 From: Tim Heap Date: Mon, 18 May 2026 17:16:19 +1000 Subject: [PATCH 2/4] Bump action versions to silence warnings They all ran on old node v20 which is being deprecated. --- .../actions/build-python-package/action.yaml | 6 ++--- .github/actions/environment/action.yaml | 6 ++--- .github/workflows/ci.yaml | 23 ++++++++++--------- .github/workflows/release-tags.yaml | 4 ++-- 4 files changed, 20 insertions(+), 19 deletions(-) diff --git a/.github/actions/build-python-package/action.yaml b/.github/actions/build-python-package/action.yaml index 2b48b28..6aa654c 100644 --- a/.github/actions/build-python-package/action.yaml +++ b/.github/actions/build-python-package/action.yaml @@ -18,8 +18,8 @@ runs: using: composite steps: - - uses: actions/checkout@v4 - - uses: actions/setup-python@v5 + - uses: actions/checkout@v5 + - uses: actions/setup-python@v6 with: python-version: ${{ inputs.python-version }} cache: 'pip' @@ -30,7 +30,7 @@ runs: pip install build python3 -m build - - uses: actions/upload-artifact@v4 + - uses: actions/upload-artifact@v7 with: name: ${{ inputs.artifact-name }} path: "dist/" diff --git a/.github/actions/environment/action.yaml b/.github/actions/environment/action.yaml index 8b683fe..3a31ec9 100644 --- a/.github/actions/environment/action.yaml +++ b/.github/actions/environment/action.yaml @@ -29,7 +29,7 @@ runs: steps: # Used for the pip cache, not for the python version - - uses: actions/setup-python@v5 + - uses: actions/setup-python@v6 with: python-version: ${{ inputs.python-version }} cache: 'pip' @@ -39,13 +39,13 @@ runs: setup.cfg - name: Fetch built emsarray package - uses: actions/download-artifact@v4 + uses: actions/download-artifact@v8 with: name: ${{ inputs.package-artifact-name }} path: "dist/" - name: Cache conda packages - uses: actions/cache@v4 + uses: actions/cache@v5 with: path: ~/conda_pkgs_dir key: diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 7a38c50..47f746a 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -20,7 +20,7 @@ jobs: outputs: artifact-name: ${{ steps.build.outputs.artifact-name }} steps: - - uses: actions/checkout@v4 + - uses: actions/checkout@v5 - uses: ./.github/actions/build-python-package id: build with: @@ -39,8 +39,8 @@ jobs: if: startsWith(github.head_ref, 'release-') steps: - - uses: actions/checkout@v4 - - uses: actions/checkout@v4 + - uses: actions/checkout@v5 + - uses: actions/checkout@v5 with: repository: conda-forge/emsarray-feedstock path: emsarray-feedstock @@ -75,7 +75,7 @@ jobs: steps: - - uses: actions/checkout@v4 + - uses: actions/checkout@v5 - uses: ./.github/actions/environment with: python-version: ${{ matrix.python-version }} @@ -95,14 +95,14 @@ jobs: --cov-report xml:coverage-${{ matrix.python-version }}.xml - name: JUnit Report - uses: mikepenz/action-junit-report@v5 + uses: mikepenz/action-junit-report@v6 if: always() with: report_paths: 'junit-py*.xml' check_name: "JUnit Test Report - python ${{ matrix.python-version }}, ${{ matrix.dependencies }} dependencies" - name: MPL image comparison report - uses: actions/upload-artifact@v4 + uses: actions/upload-artifact@v7 if: ${{ failure() }} with: name: "MPL image comparison report - python ${{ matrix.python-version }}, ${{ matrix.dependencies }} dependencies" @@ -110,7 +110,8 @@ jobs: # No guarantee that the test failures were due to image comparisons if-no-files-found: 'ignore' - - uses: actions/upload-artifact@v4 + - name: Code coverage report + uses: actions/upload-artifact@v7 with: name: Code coverage for Python ${{ matrix.python-version }}, ${{ matrix.dependencies }} dependencies path: coverage-*.xml @@ -125,14 +126,14 @@ jobs: shell: bash -l {0} steps: - - uses: actions/checkout@v4 + - uses: actions/checkout@v5 - uses: ./.github/actions/environment with: python-version: ${{ env.python-version }} package-artifact-name: ${{ needs.build.outputs.artifact-name }} - name: 'mypy cache' - uses: actions/cache@v4 + uses: actions/cache@v5 with: path: '.mypy_cache' key: mypy-${{ runner.os }}-py${{ env.python-version }}-${{ hashFiles(format('continuous-integration/requirements-{0}.txt', env.python-version)) }} @@ -151,7 +152,7 @@ jobs: shell: bash -l {0} steps: - - uses: actions/checkout@v4 + - uses: actions/checkout@v5 - uses: ./.github/actions/environment with: python-version: ${{ env.python-version }} @@ -181,7 +182,7 @@ jobs: sphinx-build -b dirhtml -aEW . _build/dirhtml - name: Store compiled docs artifact - uses: actions/upload-artifact@v4 + uses: actions/upload-artifact@v7 with: name: Docs path: docs/_build/dirhtml diff --git a/.github/workflows/release-tags.yaml b/.github/workflows/release-tags.yaml index 57fd778..3c14da3 100644 --- a/.github/workflows/release-tags.yaml +++ b/.github/workflows/release-tags.yaml @@ -15,7 +15,7 @@ jobs: outputs: artifact-name: ${{ steps.build.outputs.artifact-name }} steps: - - uses: actions/checkout@v4 + - uses: actions/checkout@v5 - uses: ./.github/actions/build-python-package id: build with: @@ -28,7 +28,7 @@ jobs: steps: - name: Fetch Python package - uses: actions/download-artifact@v4 + uses: actions/download-artifact@v8 with: name: ${{ needs.build.outputs.artifact-name }} path: "dist" From 4a32a5622d8c285e80c1812fa8714ecd0e3ca572 Mon Sep 17 00:00:00 2001 From: Tim Heap Date: Tue, 19 May 2026 10:51:01 +1000 Subject: [PATCH 3/4] Update junit report options --- .github/workflows/ci.yaml | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 47f746a..93e6a9a 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -83,6 +83,12 @@ jobs: dependencies: ${{ matrix.dependencies }} strict: "true" + - run: | + echo "MATRIX_TAG=py${MATRIX_PYTHON_VERSION}-${MATRIX_DEPENDENCIES}-deps" >> "$GITHUB_ENV" + env: + MATRIX_PYTHON_VERSION: ${{ matrix.python-version }} + MATRIX_DEPENDENCIES: ${{ matrix.dependencies }} + - name: Run tests shell: bash -l {0} run: | @@ -90,16 +96,18 @@ jobs: --mpl \ --mpl-results-path=./mpl-results \ --mpl-generate-summary html \ - --junitxml=junit-py${{ matrix.python-version }}.xml \ + --junitxml=junit-${MATRIX_TAG}.xml \ --cov --cov-report term \ - --cov-report xml:coverage-${{ matrix.python-version }}.xml + --cov-report xml:coverage-${MATRIX_TAG}.xml - - name: JUnit Report + - name: JUnit report uses: mikepenz/action-junit-report@v6 if: always() with: report_paths: 'junit-py*.xml' - check_name: "JUnit Test Report - python ${{ matrix.python-version }}, ${{ matrix.dependencies }} dependencies" + check_name: "JUnit test report - ${{ env.MATRIX_TAG }}" + annotate_only: true + job_summary: false - name: MPL image comparison report uses: actions/upload-artifact@v7 From 8dff38fae0eefd8f9404b8c944c10d0f53f2c07b Mon Sep 17 00:00:00 2001 From: Tim Heap Date: Mon, 18 May 2026 17:24:00 +1000 Subject: [PATCH 4/4] Add release note --- docs/releases/development.rst | 2 ++ 1 file changed, 2 insertions(+) diff --git a/docs/releases/development.rst b/docs/releases/development.rst index 636fa7d..02a961b 100644 --- a/docs/releases/development.rst +++ b/docs/releases/development.rst @@ -37,3 +37,5 @@ Next release (in development) * Monkeypatch the cartopy GSHHS downloader to use the new URL from the University of Hawaii (:pr:`225`, :pr:`SciTools/cartopy#2659`). +* Silence all warnings in CI + (:pr:`227`).