fixup! valueflow: forward lifetimes through array and member subobjects

francois-berder · francois-berder · commit e3afc012c966 · 2026-06-05T14:09:39.000+02:00
diff --git a/lib/valueflow.cpp b/lib/valueflow.cpp
@@ -2034,8 +2034,8 @@ static void valueFlowForwardLifetime(Token * tok, const TokenList &tokenlist, Er
                     val.lifetimeKind = ValueFlow::Value::LifetimeKind::SubObject;
             }
             std::vector<const Token*> parents = getLhsLifetimeParents(parent->astOperand1(), settings.library);
-            for (const Token *parent : parents)
-                valueFlowForward(nextExpression, endOfVarScope, parent, values, tokenlist, errorLogger, settings);
+            for (const Token *p : parents)
+                valueFlowForward(nextExpression, endOfVarScope, p, values, tokenlist, errorLogger, settings);
         }
         // Constructor
     } else if (Token::simpleMatch(parent, "{") && !isScopeBracket(parent)) {

Original file line number	Diff line number	Diff line change
`@@ -2034,8 +2034,8 @@ static void valueFlowForwardLifetime(Token * tok, const TokenList &tokenlist, Er`
`2034`	`2034`	`val.lifetimeKind = ValueFlow::Value::LifetimeKind::SubObject;`
`2035`	`2035`	`}`
`2036`	`2036`	`std::vector<const Token*> parents = getLhsLifetimeParents(parent->astOperand1(), settings.library);`
`2037`		`- for (const Token *parent : parents)`
`2038`		`- valueFlowForward(nextExpression, endOfVarScope, parent, values, tokenlist, errorLogger, settings);`
	`2037`	`+ for (const Token *p : parents)`
	`2038`	`+ valueFlowForward(nextExpression, endOfVarScope, p, values, tokenlist, errorLogger, settings);`
`2039`	`2039`	`}`
`2040`	`2040`	`// Constructor`
`2041`	`2041`	`} else if (Token::simpleMatch(parent, "{") && !isScopeBracket(parent)) {`