fixup! fixup! fixup! Fix #8260 Improve check: Pointer calculation result not null

Author: francois-berder

lib/checkcondition.cpp

@@ -1881,7 +1881,7 @@ void CheckConditionImpl::pointerAdditionResultNotNullError(const Token *tok, con
 void CheckConditionImpl::pointerArithmeticAlwaysTrueError(const Token *tok, const Token *calc)
 {
     const std::string s = calc ? calc->expressionString() : "ptr+1";
-    reportError(tok, Severity::warning, "pointerAdditionResultNotNull", "Pointer expression '" + s + "' is always true unless there is pointer overflow, and pointer overflow is undefined behaviour.");
+    reportError(tok, Severity::warning, "pointerArithmeticAlwaysTrue", "Pointer expression '" + s + "' is always true unless there is pointer overflow, and pointer overflow is undefined behaviour.");
 }
 
 void CheckConditionImpl::checkDuplicateConditionalAssign()

test/testcondition.cpp

@@ -6259,13 +6259,13 @@ class TestCondition : public TestFixture {
               "  int *q = ptr + 1;\n"
               "  if (q);\n"
               "}");
-        ASSERT_EQUALS("[test.cpp:3:7]: (warning) Pointer expression 'q' is always true unless there is pointer overflow, and pointer overflow is undefined behaviour. [pointerAdditionResultNotNull]\n", errout_str());
+        ASSERT_EQUALS("[test.cpp:3:7]: (warning) Pointer expression 'q' is always true unless there is pointer overflow, and pointer overflow is undefined behaviour. [pointerArithmeticAlwaysTrue]\n", errout_str());
 
         check("void f(char *ptr) {\n"
               "  int *q = ptr + 1;\n"
               "  if (!q);\n"
               "}");
-        ASSERT_EQUALS("[test.cpp:3:8]: (warning) Pointer expression 'q' is always true unless there is pointer overflow, and pointer overflow is undefined behaviour. [pointerAdditionResultNotNull]\n", errout_str());
+        ASSERT_EQUALS("[test.cpp:3:8]: (warning) Pointer expression 'q' is always true unless there is pointer overflow, and pointer overflow is undefined behaviour. [pointerArithmeticAlwaysTrue]\n", errout_str());
 
         check("void f(char *ptr) {\n"
               "  int *q = ptr + 0;\n"