From 4edf622fb7d92a20d491851c05ba97d0e86b1368 Mon Sep 17 00:00:00 2001 From: codethinki Date: Wed, 18 Feb 2026 20:25:03 +0100 Subject: [PATCH 1/5] ci modifications (partial) --- .github/workflows/build-test.yml | 1 - .github/workflows/check-clang-format.yml | 15 +++++++++++++++ 2 files changed, 15 insertions(+), 1 deletion(-) create mode 100644 .github/workflows/check-clang-format.yml diff --git a/.github/workflows/build-test.yml b/.github/workflows/build-test.yml index 7f4c5c0..4ea8656 100644 --- a/.github/workflows/build-test.yml +++ b/.github/workflows/build-test.yml @@ -3,7 +3,6 @@ name: Build & Test on: push: { branches: ["master", "_master/add_ci"] } pull_request: { branches: ["master"] } - workflow_dispatch: permissions: { contents: read, packages: write } diff --git a/.github/workflows/check-clang-format.yml b/.github/workflows/check-clang-format.yml new file mode 100644 index 0000000..925d899 --- /dev/null +++ b/.github/workflows/check-clang-format.yml @@ -0,0 +1,15 @@ +name: Clang Format + +on: [push, pull_request] + +permissions: { contents: read } +jobs: + formatting-check: + name: Format check + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v2 + - name: Run clang-format style check for C/C++ programs. + uses: jidicula/clang-format-action@v4.2.0 + with: + clang-format-version: '13' From 5963343c044ec04b92bcd3a842f9c95826281551 Mon Sep 17 00:00:00 2001 From: codethinki Date: Sat, 21 Feb 2026 19:32:23 +0100 Subject: [PATCH 2/5] i think i moved the docker images to cache/ now --- .github/actions/build-container/action.yml | 22 +++++++++++++++++++--- .github/workflows/linux-pipeline.yml | 7 +++++-- 2 files changed, 24 insertions(+), 5 deletions(-) diff --git a/.github/actions/build-container/action.yml b/.github/actions/build-container/action.yml index 72a9cfb..14fafb7 100644 --- a/.github/actions/build-container/action.yml +++ b/.github/actions/build-container/action.yml @@ -7,6 +7,14 @@ inputs: tag: description: 'Tag suffix for the image' required: true + image-subdir: + description: 'Subdirectory to push image to' + default: 'cache' + +outputs: + container-image-adress: + description: Address of container image + value: ${{ steps.set-image.outputs.image }} runs: using: "composite" @@ -14,6 +22,14 @@ runs: - name: Set up Docker Buildx uses: docker/setup-buildx-action@v3 + - name: Set image names + id: set-image + shell: bash + run: | + image="ghcr.io/${{ github.repository }}/{{inputs.image-subdir}}:${{ inputs.tag }}" + echo "image=$image" >> $GITHUB_OUTPUT + echo "cache_image=${image}-cache" >> $GITHUB_OUTPUT + - name: Log in to the Container registry uses: docker/login-action@v3 with: @@ -27,6 +43,6 @@ runs: context: . file: ${{ inputs.dockerfile }} push: true - tags: ghcr.io/${{ github.repository }}:${{ inputs.tag }} - cache-from: type=registry,ref=ghcr.io/${{ github.repository }}:${{ inputs.tag }}-cache - cache-to: type=registry,ref=ghcr.io/${{ github.repository }}:${{ inputs.tag }}-cache,mode=max \ No newline at end of file + tags: ${{ steps.set-image.outputs.image }} + cache-from: type=registry,ref=${{ steps.set-image.outputs.cache_image }} + cache-to: type=registry,ref=${{ steps.set-image.outputs.cache_image }},mode=max \ No newline at end of file diff --git a/.github/workflows/linux-pipeline.yml b/.github/workflows/linux-pipeline.yml index f3047f3..2cf9fc9 100644 --- a/.github/workflows/linux-pipeline.yml +++ b/.github/workflows/linux-pipeline.yml @@ -21,9 +21,12 @@ jobs: prepare: name: Build Container (${{ inputs.backend }}) runs-on: ubuntu-latest + outputs: + container-image-adress: ${{ steps.build.outputs.container-image-adress }} steps: - uses: actions/checkout@v4 - - name: Build & Push + - id: build + name: Build & Push uses: ./.github/actions/build-container with: dockerfile: ci/docker/linux/Dockerfile.${{ inputs.backend }} @@ -34,7 +37,7 @@ jobs: needs: prepare runs-on: ubuntu-latest container: - image: ghcr.io/${{ github.repository }}:linux-${{ inputs.backend }} + image: ${{ needs.prepare.outputs.container-image-adress }} credentials: username: ${{ github.actor }} password: ${{ github.token }} From 9f3343294a97e62e82d8154475c2f40a64759722 Mon Sep 17 00:00:00 2001 From: codethinki Date: Sat, 21 Feb 2026 19:34:48 +0100 Subject: [PATCH 3/5] removed the clang format check this was meant for another branch --- .github/workflows/check-clang-format.yml | 15 --------------- 1 file changed, 15 deletions(-) delete mode 100644 .github/workflows/check-clang-format.yml diff --git a/.github/workflows/check-clang-format.yml b/.github/workflows/check-clang-format.yml deleted file mode 100644 index 925d899..0000000 --- a/.github/workflows/check-clang-format.yml +++ /dev/null @@ -1,15 +0,0 @@ -name: Clang Format - -on: [push, pull_request] - -permissions: { contents: read } -jobs: - formatting-check: - name: Format check - runs-on: ubuntu-latest - steps: - - uses: actions/checkout@v2 - - name: Run clang-format style check for C/C++ programs. - uses: jidicula/clang-format-action@v4.2.0 - with: - clang-format-version: '13' From c61cde87ef8f3b8d0939b4aec675821a88a17768 Mon Sep 17 00:00:00 2001 From: codethinki Date: Sat, 21 Feb 2026 19:36:26 +0100 Subject: [PATCH 4/5] forgot the $ sign --- .github/actions/build-container/action.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/actions/build-container/action.yml b/.github/actions/build-container/action.yml index 14fafb7..c351b28 100644 --- a/.github/actions/build-container/action.yml +++ b/.github/actions/build-container/action.yml @@ -26,7 +26,7 @@ runs: id: set-image shell: bash run: | - image="ghcr.io/${{ github.repository }}/{{inputs.image-subdir}}:${{ inputs.tag }}" + image="ghcr.io/${{ github.repository }}/${{ inputs.image-subdir }}:${{ inputs.tag }}" echo "image=$image" >> $GITHUB_OUTPUT echo "cache_image=${image}-cache" >> $GITHUB_OUTPUT From 83401f8b94178b4605c46825923b80bfd8518e08 Mon Sep 17 00:00:00 2001 From: codethinki Date: Sat, 21 Feb 2026 20:18:19 +0100 Subject: [PATCH 5/5] added -container suffix for docker container binaries --- .github/workflows/linux-pipeline.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/linux-pipeline.yml b/.github/workflows/linux-pipeline.yml index 2cf9fc9..65ced60 100644 --- a/.github/workflows/linux-pipeline.yml +++ b/.github/workflows/linux-pipeline.yml @@ -30,7 +30,7 @@ jobs: uses: ./.github/actions/build-container with: dockerfile: ci/docker/linux/Dockerfile.${{ inputs.backend }} - tag: linux-${{ inputs.backend }} + tag: linux-${{ inputs.backend }}-container build: name: Linux (${{ inputs.compiler }}-${{ inputs.backend }})