From ec34daba1c2765d3e14c808a21f152edfb0f7411 Mon Sep 17 00:00:00 2001 From: Mohsen Nasiri <1129811+mohsenny@users.noreply.github.com> Date: Mon, 31 Aug 2026 16:41:33 +0200 Subject: [PATCH] Fix PHP 8.4 implicit nullable deprecation in Formatter\Links PHP 8.4 deprecates implicitly nullable parameter types. The $internal_domains parameter defaults to null but is typed `array`, which emits a deprecation notice on PHP 8.4+. The backing property is already declared `?array`, and $filter_by on the same signature already uses `?string`, so this makes the second parameter consistent with both. Co-Authored-By: Claude Opus 5 --- classes/Formatter/Links.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/classes/Formatter/Links.php b/classes/Formatter/Links.php index 4a59799eb..8a363e225 100644 --- a/classes/Formatter/Links.php +++ b/classes/Formatter/Links.php @@ -16,7 +16,7 @@ class Links implements Formatter private ?array $internal_domains; - public function __construct(?string $filter_by = null, array $internal_domains = null) + public function __construct(?string $filter_by = null, ?array $internal_domains = null) { $this->filter_by = $filter_by; $this->internal_domains = $internal_domains;