Skip to content

Final work for phone verification deployment #2140

@J-C-L

Description

@J-C-L

Summary
Most of the work is done for the Phone Number Verification workflow. Before we deploy to prod we need to do a few final tasks.

Success Criteria

  • 1. Change verification check before being directed to submit testimony from just email to email and phone in the following places (will have to check phoneVerified from user’s Firestore profile document):

    Confirm that on Bill, Ballot Question and Testimony Detail pages, the CTA to submit testimony directs users who have not verified BOTH email and phone to their Profile Page. Examples: here, here, and here.

  • 2. Change the user facing language FROM Verify Your Email TO Verify Your Account here:
    That will update the language on the bill, ballot question, and testimony CTAs
    here, here, and here

  • 3. Change verification check from just email to email and phone for redirect away from submit testimony page (will have to check phoneVerified from user’s Firestore profile document). Change code here.

    Confirm that a user who has not verified both email and phone is automatically redirected to Profile Page from Submit Testimony Page. Example here

  • 4. Check this test didn’t break.

  • 5. Remove the phoneVerificationUI feature flag in the following places:

    • EditProfilePage.tsx
    • ProfilePage.tsx
    • ProfilePage.stories.tsx
    • featureFlags.ts
  • 6. Get rid of VerifyAccountSectionLegacy.tsx, and the reference to it in Profile.Page.tsx (used when phoneVerificationUI feature flag is off)

  • 7. Make announcement banner

    • Clarify which pages we want to put the banner on (Only on home page or across all pages?
    • Clarify how long to leave banner up?
      Can use AnnouncementBanner component
      See figma here for wording (will need to link to edit profile if logged in, or sign up modal if not)
  • 8. Add this to our deploy checklist for PROD when we're ready to go live:
    “Add IAM permissions so "allUsers" has Role "Cloud Functions Invoker" for completePhoneVerification”`

  • 9. Add the following description of how to test phone verification workflow as a note on the Github Wiki / README.
    Phone number verification workflow test steps:
    * Create new user account
    * Navigate to edit profile page . On Phone Number side of verify account section, click "Verify".
    * Go through the steps in the "Verify Phone" pop-up modal. Use phone number: 650-555-1234 and code: 123456. (Or can add new testing phone number in Firebase Console > Authentication > Sign-In Method > Phone ? Phone numbers for testing). Confirm that the Phone number side now says "Successfully verified. Thank you!"
    * Go to Firebase console > Authentication > Users
    Find the user you created. Confirm the phone icon is showing under "providers"
    * Go to Firebase console > Firestore > Profiles.
    Filer by fullName and find your user.
    Confirm it has field phoneVerified: true

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions