From 8f1b18be3c59a4e0fe96bab49e42726a1a034ca1 Mon Sep 17 00:00:00 2001 From: Morgan Roderick Date: Sat, 19 Sep 2026 09:01:18 +0200 Subject: [PATCH] chore(spec): drop :js tag where the rack_test driver suffices These scenarios only use visit, fill_in, check, click and text expectations against server-rendered pages with no JavaScript widgets, so they run fine under the default rack_test driver instead of Playwright. This also avoids the slower truncation database strategy that the :js tag forces in spec_helper. --- spec/features/admin/add_user_to_workshop_spec.rb | 2 +- spec/features/admin/manage_workshop_attendances_spec.rb | 2 +- spec/features/viewing_pages_spec.rb | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/spec/features/admin/add_user_to_workshop_spec.rb b/spec/features/admin/add_user_to_workshop_spec.rb index 08ca255f2..3f9803567 100644 --- a/spec/features/admin/add_user_to_workshop_spec.rb +++ b/spec/features/admin/add_user_to_workshop_spec.rb @@ -1,6 +1,6 @@ require 'rails_helper' -RSpec.describe 'Add a user to an existing workshop', :js do +RSpec.describe 'Add a user to an existing workshop' do let(:member) { Fabricate(:member) } let!(:juliet) { Fabricate(:member, name: 'Juliet', surname: 'Capulet') } diff --git a/spec/features/admin/manage_workshop_attendances_spec.rb b/spec/features/admin/manage_workshop_attendances_spec.rb index 9bfffdec1..c67acfc07 100644 --- a/spec/features/admin/manage_workshop_attendances_spec.rb +++ b/spec/features/admin/manage_workshop_attendances_spec.rb @@ -64,7 +64,7 @@ expect(page).to have_css('i.fa-hat-wizard') end - scenario 'can rsvp an invited student to the workshop', :js do + scenario 'can rsvp an invited student to the workshop' do login_as_admin(member) other_invitation = Fabricate(:workshop_invitation, workshop:, attending: nil) diff --git a/spec/features/viewing_pages_spec.rb b/spec/features/viewing_pages_spec.rb index 987a5801e..13a78971b 100644 --- a/spec/features/viewing_pages_spec.rb +++ b/spec/features/viewing_pages_spec.rb @@ -15,7 +15,7 @@ expect(page).to have_text('Your privacy means a lot to us') end - scenario 'can access page not found', :js do + scenario 'can access page not found' do visit '/does_not_exist' expect(page).to have_text('Page not found')