AGENT_FARM_DIR has no env override — test harness cannot sandbox ~/.agent-farm/global.db

[waleedkadous]

Context

PR #1325 (issue #1323) introduced a global vitest harness that sandboxes user-global side effects reachable from test suites: the agy binary (CODEV_AGY_BIN) and the consult metrics DB (CODEV_METRICS_DB). During integration review, the remaining unpinnable user-global surface was identified: ~/.agent-farm/global.db.

Problem

AGENT_FARM_DIR (packages/core/src/constants.ts:5) is a module-load-time resolve(homedir(), '.agent-farm') with no environment override. Any in-process test that touches agent-farm state reads/writes the developer's real global.db, and the #1325 harness has no lever to redirect it.

This is the same failure-of-omission shape #1323 fixed for agy/metrics: safety currently depends on every test remembering not to touch agent-farm paths.

Proposed fix

• Add an env override (e.g. CODEV_AGENT_FARM_DIR) honoured at the AGENT_FARM_DIR definition. Note it is a module-load-time constant — the override must be read at import time, which the vitest harness's setupFiles ordering already satisfies; document that constraint.
• Pin it to the per-run sandbox in packages/codev/vitest-setup.ts alongside the existing agy/metrics pins.
• Optional belt-and-braces: refuse to open the real global.db under a test runner without the override, mirroring resolveDbPath() in metrics.ts.

Origin

Raised by the claude integration-review lane on PR #1325; filed by the architect so #1325 ships without scope growth.

Related

• Test-suite consult runs escape isolation: real agy spawns (login-window burst) + user-global metrics DB pollution #1323 / PR [Bugfix #1323] Sandbox agy + metrics DB for every test suite #1325 — the harness this extends
• Consolidate state.db tables into global.db (single user-global database) to eliminate the cwd-dependent fragmentation that causes "missing architect state after restart" #1118 — global.db consolidation (why this file is THE state surface)