From 5b5328e180754c53f8a583dd96441fa2ba7e3d8d Mon Sep 17 00:00:00 2001 From: erezrokah Date: Mon, 3 Aug 2026 15:19:56 +0100 Subject: [PATCH] fix: Unblock dependency updates - Guard null buffer in JSON scalar toString, which @apache-arrow/esnext-esm 21.2.0 rejects (TS2345 on TextDecoder.decode) - Drop redundant Promise.resolve return in sync, flagged by eslint-plugin-unicorn 72 - Hold typescript at <7 until typescript-eslint supports it --- .github/renovate.json5 | 7 +++++++ src/scalar/json.ts | 2 +- src/scheduler/scheduler.ts | 1 - 3 files changed, 8 insertions(+), 2 deletions(-) diff --git a/.github/renovate.json5 b/.github/renovate.json5 index b623065..3ba04f9 100644 --- a/.github/renovate.json5 +++ b/.github/renovate.json5 @@ -1,3 +1,10 @@ { extends: ["github>cloudquery/.github//.github/renovate-node-default.json5"], + packageRules: [ + { + // typescript-eslint does not support TS 7 yet: https://github.com/typescript-eslint/typescript-eslint/issues/10940 + matchPackageNames: ["typescript"], + allowedVersions: "<7", + }, + ], } diff --git a/src/scalar/json.ts b/src/scalar/json.ts index 744da7b..24d1e19 100644 --- a/src/scalar/json.ts +++ b/src/scalar/json.ts @@ -72,7 +72,7 @@ class JSONType implements Scalar> { } public toString() { - if (this._valid) { + if (this._valid && this._value !== null) { return new TextDecoder().decode(this._value); } diff --git a/src/scheduler/scheduler.ts b/src/scheduler/scheduler.ts index 6e4bd79..ad9f4f9 100644 --- a/src/scheduler/scheduler.ts +++ b/src/scheduler/scheduler.ts @@ -269,5 +269,4 @@ export const sync = async ({ } stream.end(); - return await Promise.resolve(); };