AbstractAuthenticationConfiguration incorrectly sets the getLinkText property as Boolean instead of String

[SaifuddinMerchant]

AbstractAuthenticationConfiguration incorrectly sets the getLinkText property as Boolean instead of String

When running the integration test locally, I get an error -

https://github.com/cloudfoundry/cf-java-client/blob/main/cloudfoundry-client/src/main/java/org/cloudfoundry/uaa/identityproviders/AbstractAuthenticationConfiguration.java#L42-L47

Caused by: com.fasterxml.jackson.databind.exc.InvalidFormatException: Cannot deserialize value of type java.lang.Boolean from String "Login with Provider xyz": only "true" or "false" recognized
at [Source: (byte[])"[{"type":"oidc1.0","config":{"emailDomain":null,"additionalConfiguration":null,"providerDescription":null,"externalGroupsWhitelist":

According to the specs this property should be a String not a Boolean
https://docs.cloudfoundry.org/api/uaa/version/77.34.0/index.html#oauth-oidc

P.S. The show link text is correct and should be a boolean
https://github.com/cloudfoundry/cf-java-client/blob/main/cloudfoundry-client/src/main/java/org/cloudfoundry/uaa/identityproviders/AbstractAuthenticationConfiguration.java#L69-L75

[Kehrlann]

Thanks for the report @SaifuddinMerchant ! Please feel free to submit a fix.

I'm not seeing the error in integration tests myself, which one is failing exactly?

[SaifuddinMerchant]

It just fails to load the integration test. I'll post the full error so it's clear. My guess is that because we have an alternate provider setup in the system and we actually return a value. As the field is optional, it might not be happening where you run the test.

Yes I plan to submit the fix, hopefully in the next few days

[SaifuddinMerchant]

Without the fix,

$ mvn -Pintegration-test test -Dtest=org.cloudfoundry.client.v3.SecurityGroupsTest#listWithPagination

[ERROR] org.cloudfoundry.client.v3.SecurityGroupsTest.listWithPagination -- Time elapsed: 0 s <<< ERROR!
java.lang.IllegalStateException: Failed to load ApplicationContext
at org.springframework.test.context.cache.DefaultCacheAwareContextLoaderDelegate.loadContext(DefaultCacheAwareContextLoaderDelegate.java:98)
at org.springframework.test.context.support.DefaultTestContext.getApplicationContext(DefaultTestContext.java:124)
at org.springframework.test.context.support.DependencyInjectionTestExecutionListener.injectDependencies(DependencyInjectionTestExecutionListener.java:118)
at org.springframework.test.context.support.DependencyInjectionTestExecutionListener.prepareTestInstance(DependencyInjectionTestExecutionListener.java:83)
...
...
Caused by: org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'cloudFoundryCleaner' defined in org.cloudfoundry.IntegrationTestConfiguration: Invocation of init method failed; nested exception is org.cloudfoundry.reactor.util.JsonParsingException: Cannot deserialize value of type java.lang.Boolean from String "Login with Provider xyz": only "true" or "false" recognized
at [Source: (byte[])"[{"type":"oidc1.0","config":{"emailDomain":null,"additionalConfiguration":null,"providerDescription":null,"externalGroupsWhitelist":[],"attributeMappings":{"external_groups":"groups","email":"email","user_name":"sub"},"addShadowUserOnLogin":true,"storeCustomAttributes":true,"authUrl":"https://provider/authorize","tokenUrl":"https://provider/token","tokenKeyUrl":"https://provider/jwks","tokenKey":null,"[truncated 3328 bytes]; line: 1, column: 1048] (through reference chain: java.util.ArrayList[0]->org.cloudfoundry.uaa.identityproviders.OpenIdConnectConfiguration$Json["linkText"])
at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.initializeBean(AbstractAutowireCapableBeanFactory.java:1804)
at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.doCreateBean(AbstractAutowireCapableBeanFactory.java:620)
...
...
at org.springframework.test.context.cache.DefaultCacheAwareContextLoaderDelegate.loadContext(DefaultCacheAwareContextLoaderDelegate.java:90)
... 71 more
Caused by: org.cloudfoundry.reactor.util.JsonParsingException: Cannot deserialize value of type java.lang.Boolean from String "Login with Provider xyz": only "true" or "false" recognized
at [Source: (byte[])"[{"type":"oidc1.0","config":{"emailDomain":null,"additionalConfiguration":null,"providerDescription":null,"externalGroupsWhitelist":[],"attributeMappings":{"external_groups":"groups","email":"email","user_name":"sub"},"addShadowUserOnLogin":true,"storeCustomAttributes":true,"authUrl":"https://provider/authorize","tokenUrl":"https://provider/token","tokenKeyUrl":"https://provider/jwks","tokenKey":null,"[truncated 3328 bytes]; line: 1, column: 1048] (through reference chain: java.util.ArrayList[0]->org.cloudfoundry.uaa.identityproviders.OpenIdConnectConfiguration$Json["linkText"])
at org.cloudfoundry.reactor.util.JsonCodec.lambda$decode$0(JsonCodec.java:52)
Suppressed: The stacktrace has been enhanced by Reactor, refer to additional information below:

[INFO]
[INFO] Results:
[INFO]
[ERROR] Errors:
[ERROR] org.cloudfoundry.client.v3.SecurityGroupsTest.listWithPagination
[ERROR] Run 1: SecurityGroupsTest.listWithPagination » IllegalState Failed to load ApplicationContext
[ERROR] Run 2: SecurityGroupsTest.listWithPagination » IllegalState Failed to load ApplicationContext
[ERROR] Run 3: SecurityGroupsTest.listWithPagination » IllegalState Failed to load ApplicationContext
[ERROR] Run 4: SecurityGroupsTest.listWithPagination » IllegalState Failed to load ApplicationContext
[INFO]
[INFO]
[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0

---

With Fix

$ mvn -Pintegration-test test -Dtest=org.cloudfoundry.client.v3.SecurityGroupsTest#listWithPagination
[INFO] Running org.cloudfoundry.client.v3.SecurityGroupsTest
08:16:27.314 main cloudfoundry-client.test Performing clean slate cleanup. Should happen once per integration test run.
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 10.93 s -- in org.cloudfoundry.client.v3.SecurityGroupsTest

[INFO] Results:
[INFO]
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS

[Kehrlann]

Closed in #1301