From 8d3d0ca9c1c4296d695d112bb72a5487975ca2c3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Javier=20P=C3=A9rez?= Date: Thu, 29 Oct 2026 19:23:42 +0100 Subject: [PATCH] ci: keep a failed Slack notification from failing a release The 10.1.0 release stopped after both prerelease packages were published. The Slack webhook answered 403, which failed the prerelease job. The release job depends on it, so the production approval never appeared. The four Slack notification steps now continue on error. --- .github/workflows/release.yml | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 15d47d77..90d2d66c 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -110,6 +110,8 @@ jobs: # Slack failure alert - name: Slack Failure Notification if: ${{ failure() }} + # A failed Slack notification must not fail the job: a later job of the release needs it. + continue-on-error: true uses: rtCamp/action-slack-notify@33ca3be66c6f378fe1610fd1d5258632dbed5e58 # v2.4.0 env: SLACK_USERNAME: Checkly Github Bot @@ -123,6 +125,8 @@ jobs: # Slack success alert - name: Slack Success Notification if: ${{ success() }} + # A failed Slack notification must not fail the job: a later job of the release needs it. + continue-on-error: true uses: rtCamp/action-slack-notify@33ca3be66c6f378fe1610fd1d5258632dbed5e58 # v2.4.0 env: SLACK_USERNAME: Checkly Github Bot @@ -175,6 +179,8 @@ jobs: # Slack failure alert - name: Slack Failure Notification if: ${{ failure() }} + # A failed Slack notification must not fail the job: a later job of the release needs it. + continue-on-error: true uses: rtCamp/action-slack-notify@33ca3be66c6f378fe1610fd1d5258632dbed5e58 # v2.4.0 env: SLACK_USERNAME: Checkly Github Bot @@ -188,6 +194,8 @@ jobs: # Slack success alert - name: Slack Success Notification if: ${{ success() }} + # A failed Slack notification must not fail the job: a later job of the release needs it. + continue-on-error: true uses: rtCamp/action-slack-notify@33ca3be66c6f378fe1610fd1d5258632dbed5e58 # v2.4.0 env: SLACK_USERNAME: Checkly Github Bot