diff --git a/CefSharp.BrowserSubprocess.Core/CefAppUnmanagedWrapper.cpp b/CefSharp.BrowserSubprocess.Core/CefAppUnmanagedWrapper.cpp index 6ad271d002..7c01d7d413 100644 --- a/CefSharp.BrowserSubprocess.Core/CefAppUnmanagedWrapper.cpp +++ b/CefSharp.BrowserSubprocess.Core/CefAppUnmanagedWrapper.cpp @@ -301,7 +301,7 @@ namespace CefSharp frame->SendProcessMessage(CefProcessId::PID_BROWSER, uncaughtExceptionMessage); } - JavascriptRootObjectWrapper^ CefAppUnmanagedWrapper::GetJsRootObjectWrapper(int browserId, CefString& frameId) + JavascriptRootObjectWrapper^ CefAppUnmanagedWrapper::GetJsRootObjectWrapper(int browserId, CefString frameId) { auto rootObjectWrappers = _jsRootObjectWrappersByFrameId; diff --git a/CefSharp.BrowserSubprocess.Core/CefAppUnmanagedWrapper.h b/CefSharp.BrowserSubprocess.Core/CefAppUnmanagedWrapper.h index b989c3467a..f74891eaaf 100644 --- a/CefSharp.BrowserSubprocess.Core/CefAppUnmanagedWrapper.h +++ b/CefSharp.BrowserSubprocess.Core/CefAppUnmanagedWrapper.h @@ -85,7 +85,7 @@ namespace CefSharp } CefBrowserWrapper^ FindBrowserWrapper(int browserId); - JavascriptRootObjectWrapper^ GetJsRootObjectWrapper(int browserId, CefString& frameId); + JavascriptRootObjectWrapper^ GetJsRootObjectWrapper(int browserId, CefString frameId); virtual DECL CefRefPtr GetRenderProcessHandler() override; virtual DECL void OnBrowserCreated(CefRefPtr browser, CefRefPtr extraInfo) override; diff --git a/CefSharp.BrowserSubprocess.Core/CefBrowserWrapper.h b/CefSharp.BrowserSubprocess.Core/CefBrowserWrapper.h index 12ce17ba47..37f03c1dd0 100644 --- a/CefSharp.BrowserSubprocess.Core/CefBrowserWrapper.h +++ b/CefSharp.BrowserSubprocess.Core/CefBrowserWrapper.h @@ -30,7 +30,7 @@ namespace CefSharp MCefRefPtr _cefBrowser; public: - CefBrowserWrapper(CefRefPtr cefBrowser) + CefBrowserWrapper(const CefRefPtr &cefBrowser) { _cefBrowser = cefBrowser.get(); BrowserId = cefBrowser->GetIdentifier(); diff --git a/CefSharp.BrowserSubprocess.Core/CefSharp.BrowserSubprocess.Core.netcore.vcxproj b/CefSharp.BrowserSubprocess.Core/CefSharp.BrowserSubprocess.Core.netcore.vcxproj index bb5dde540e..0ddac8d205 100644 --- a/CefSharp.BrowserSubprocess.Core/CefSharp.BrowserSubprocess.Core.netcore.vcxproj +++ b/CefSharp.BrowserSubprocess.Core/CefSharp.BrowserSubprocess.Core.netcore.vcxproj @@ -154,7 +154,8 @@ Use true true - stdcpp17 + stdcpp20 + CompileAsCpp true @@ -174,7 +175,8 @@ _DEBUG;EXPORT;NETCOREAPP;%(PreprocessorDefinitions) Use true - stdcpp17 + stdcpp20 + CompileAsCpp true @@ -194,7 +196,8 @@ _DEBUG;EXPORT;NETCOREAPP;%(PreprocessorDefinitions) Use true - stdcpp17 + stdcpp20 + CompileAsCpp true @@ -214,7 +217,8 @@ Use true true - stdcpp17 + stdcpp20 + CompileAsCpp true @@ -232,7 +236,8 @@ NDEBUG;EXPORT;NETCOREAPP;%(PreprocessorDefinitions) Use true - stdcpp17 + stdcpp20 + CompileAsCpp true @@ -250,7 +255,8 @@ NDEBUG;EXPORT;NETCOREAPP;%(PreprocessorDefinitions) Use true - stdcpp17 + stdcpp20 + CompileAsCpp true diff --git a/CefSharp.BrowserSubprocess.Core/CefSharp.BrowserSubprocess.Core.vcxproj b/CefSharp.BrowserSubprocess.Core/CefSharp.BrowserSubprocess.Core.vcxproj index 2514acccc6..08b144e25c 100644 --- a/CefSharp.BrowserSubprocess.Core/CefSharp.BrowserSubprocess.Core.vcxproj +++ b/CefSharp.BrowserSubprocess.Core/CefSharp.BrowserSubprocess.Core.vcxproj @@ -111,7 +111,8 @@ true true true - stdcpp17 + stdcpp20 + CompileAsCpp true @@ -129,7 +130,8 @@ Use true true - stdcpp17 + stdcpp20 + CompileAsCpp true @@ -146,7 +148,8 @@ Use true true - stdcpp17 + stdcpp20 + CompileAsCpp true @@ -161,7 +164,8 @@ WIN32;NDEBUG;EXPORT;%(PreprocessorDefinitions) Use true - stdcpp17 + stdcpp20 + CompileAsCpp true diff --git a/CefSharp.BrowserSubprocess.Core/Stdafx.h b/CefSharp.BrowserSubprocess.Core/Stdafx.h index f080d8421a..263c6361ea 100644 --- a/CefSharp.BrowserSubprocess.Core/Stdafx.h +++ b/CefSharp.BrowserSubprocess.Core/Stdafx.h @@ -10,6 +10,8 @@ #define DECL __declspec(dllimport) #endif +#define NOMINMAX + #include #include diff --git a/CefSharp.BrowserSubprocess.Core/Wrapper/Browser.h b/CefSharp.BrowserSubprocess.Core/Wrapper/Browser.h index a81f3d1359..c105d8b37e 100644 --- a/CefSharp.BrowserSubprocess.Core/Wrapper/Browser.h +++ b/CefSharp.BrowserSubprocess.Core/Wrapper/Browser.h @@ -19,7 +19,7 @@ namespace CefSharp bool _disposed; internal: - Browser(CefRefPtr &browser) + Browser(const CefRefPtr &browser) : _browser(browser) { } diff --git a/CefSharp.BrowserSubprocess.Core/Wrapper/Frame.h b/CefSharp.BrowserSubprocess.Core/Wrapper/Frame.h index b38b767615..941d04fb4b 100644 --- a/CefSharp.BrowserSubprocess.Core/Wrapper/Frame.h +++ b/CefSharp.BrowserSubprocess.Core/Wrapper/Frame.h @@ -31,7 +31,7 @@ namespace CefSharp bool _disposed; internal: - Frame(CefRefPtr &frame) + Frame(const CefRefPtr &frame) : _frame(frame), _parentFrame(nullptr), _owningBrowser(nullptr), _syncRoot(gcnew Object()) { diff --git a/CefSharp.Core.Runtime.RefAssembly/CefSharp.Core.Runtime.netcore.cs b/CefSharp.Core.Runtime.RefAssembly/CefSharp.Core.Runtime.netcore.cs index f9fffdfabe..f6d2e2552d 100644 --- a/CefSharp.Core.Runtime.RefAssembly/CefSharp.Core.Runtime.netcore.cs +++ b/CefSharp.Core.Runtime.RefAssembly/CefSharp.Core.Runtime.netcore.cs @@ -16,6 +16,8 @@ public BrowserSettings() { } public BrowserSettings(bool autoDispose) { } public virtual bool AutoDispose { get { throw null; } } public virtual uint BackgroundColor { get { throw null; } set { } } + public virtual CefSharp.CefState ChromeStatusBubble { get { throw null; } set { } } + public virtual CefSharp.CefState ChromeZoomBubble { get { throw null; } set { } } public virtual string CursiveFontFamily { get { throw null; } set { } } public virtual CefSharp.CefState Databases { get { throw null; } set { } } public virtual string DefaultEncoding { get { throw null; } set { } } @@ -40,8 +42,6 @@ public BrowserSettings(bool autoDispose) { } public virtual CefSharp.CefState TabToLinks { get { throw null; } set { } } public virtual CefSharp.CefState TextAreaResize { get { throw null; } set { } } public virtual CefSharp.CefState WebGl { get { throw null; } set { } } - public virtual CefSharp.CefState ChromeStatusBubble { get { throw null; } set { } } - public virtual CefSharp.CefState ChromeZoomBubble { get { throw null; } set { } } public virtual int WindowlessFrameRate { get { throw null; } set { } } public void Dispose() { } protected virtual void Dispose(bool A_0) { } diff --git a/CefSharp.Core.Runtime/CefSharp.Core.Runtime.netcore.vcxproj b/CefSharp.Core.Runtime/CefSharp.Core.Runtime.netcore.vcxproj index 53bc6e63cf..043313049c 100644 --- a/CefSharp.Core.Runtime/CefSharp.Core.Runtime.netcore.vcxproj +++ b/CefSharp.Core.Runtime/CefSharp.Core.Runtime.netcore.vcxproj @@ -178,7 +178,8 @@ Stdafx.h true true - stdcpp17 + stdcpp20 + CompileAsCpp false @@ -212,7 +213,8 @@ ProgramDatabase Stdafx.h true - stdcpp17 + stdcpp20 + CompileAsCpp false @@ -243,7 +245,8 @@ ProgramDatabase Stdafx.h true - stdcpp17 + stdcpp20 + CompileAsCpp false @@ -273,7 +276,8 @@ true true true - stdcpp17 + stdcpp20 + CompileAsCpp libcef.lib;libcef_dll_wrapper.lib;%(AdditionalDependencies) @@ -297,7 +301,8 @@ ProgramDatabase true true - stdcpp17 + stdcpp20 + CompileAsCpp libcef.lib;libcef_dll_wrapper.lib;%(AdditionalDependencies) @@ -319,7 +324,8 @@ ProgramDatabase true true - stdcpp17 + stdcpp20 + CompileAsCpp libcef.lib;libcef_dll_wrapper.lib;%(AdditionalDependencies) diff --git a/CefSharp.Core.Runtime/CefSharp.Core.Runtime.vcxproj b/CefSharp.Core.Runtime/CefSharp.Core.Runtime.vcxproj index c036f4140e..62e03d7eef 100644 --- a/CefSharp.Core.Runtime/CefSharp.Core.Runtime.vcxproj +++ b/CefSharp.Core.Runtime/CefSharp.Core.Runtime.vcxproj @@ -130,7 +130,8 @@ Stdafx.h true true - stdcpp17 + stdcpp20 + CompileAsCpp false @@ -161,7 +162,8 @@ ProgramDatabase Stdafx.h true - stdcpp17 + stdcpp20 + CompileAsCpp false @@ -188,7 +190,8 @@ true true true - stdcpp17 + stdcpp20 + CompileAsCpp opengl32.lib;glu32.lib;libcef.lib;libcef_dll_wrapper.lib;%(AdditionalDependencies) @@ -209,7 +212,8 @@ ProgramDatabase true true - stdcpp17 + stdcpp20 + CompileAsCpp opengl32.lib;glu32.lib;libcef.lib;libcef_dll_wrapper.lib;%(AdditionalDependencies) diff --git a/CefSharp.Core.Runtime/DragData.h b/CefSharp.Core.Runtime/DragData.h index 48aa18fe28..b31f0af62f 100644 --- a/CefSharp.Core.Runtime/DragData.h +++ b/CefSharp.Core.Runtime/DragData.h @@ -26,7 +26,7 @@ namespace CefSharp MCefRefPtr _wrappedDragData; internal: - DragData(CefRefPtr &dragData) : + DragData(const CefRefPtr &dragData) : _wrappedDragData(dragData) { IsReadOnly = dragData->IsReadOnly(); diff --git a/CefSharp.Core.Runtime/Internals/CefBrowserHostWrapper.h b/CefSharp.Core.Runtime/Internals/CefBrowserHostWrapper.h index ca6bb5f5ca..4db8861ca7 100644 --- a/CefSharp.Core.Runtime/Internals/CefBrowserHostWrapper.h +++ b/CefSharp.Core.Runtime/Internals/CefBrowserHostWrapper.h @@ -26,7 +26,7 @@ namespace CefSharp double GetZoomLevelOnUI(); internal: - CefBrowserHostWrapper(CefRefPtr &browserHost) : _browserHost(browserHost) + CefBrowserHostWrapper(const CefRefPtr &browserHost) : _browserHost(browserHost) { } diff --git a/CefSharp.Core.Runtime/Internals/CefBrowserWrapper.h b/CefSharp.Core.Runtime/Internals/CefBrowserWrapper.h index e7a1f5c4a4..13ed5dcdb1 100644 --- a/CefSharp.Core.Runtime/Internals/CefBrowserWrapper.h +++ b/CefSharp.Core.Runtime/Internals/CefBrowserWrapper.h @@ -20,7 +20,7 @@ namespace CefSharp IBrowserHost^ _browserHost; internal: - CefBrowserWrapper::CefBrowserWrapper(CefRefPtr &browser) + CefBrowserWrapper(const CefRefPtr &browser) : _browser(browser), _browserHost(nullptr) { } diff --git a/CefSharp.Core.Runtime/Internals/CefContextMenuParamsWrapper.cpp b/CefSharp.Core.Runtime/Internals/CefContextMenuParamsWrapper.cpp index 7259b17804..fa98e45067 100644 --- a/CefSharp.Core.Runtime/Internals/CefContextMenuParamsWrapper.cpp +++ b/CefSharp.Core.Runtime/Internals/CefContextMenuParamsWrapper.cpp @@ -111,7 +111,7 @@ namespace CefSharp { ThrowIfDisposed(); - std::vector& dictionarySuggestions = std::vector(); + std::vector dictionarySuggestions; bool result = _wrappedInfo->GetDictionarySuggestions(dictionarySuggestions); return StringUtils::ToClr(dictionarySuggestions); diff --git a/CefSharp.Core.Runtime/Internals/CefFrameWrapper.h b/CefSharp.Core.Runtime/Internals/CefFrameWrapper.h index 7927e1e0ef..3493e3bdd2 100644 --- a/CefSharp.Core.Runtime/Internals/CefFrameWrapper.h +++ b/CefSharp.Core.Runtime/Internals/CefFrameWrapper.h @@ -32,7 +32,7 @@ namespace CefSharp Object^ _syncRoot; internal: - CefFrameWrapper::CefFrameWrapper(CefRefPtr &frame) + CefFrameWrapper(const CefRefPtr &frame) : _frame(frame), _parentFrame(nullptr), _owningBrowser(nullptr), _syncRoot(gcnew Object()) { diff --git a/CefSharp.Core.Runtime/Internals/CefImageWrapper.h b/CefSharp.Core.Runtime/Internals/CefImageWrapper.h index 6e69cc2a3f..4358d841c4 100644 --- a/CefSharp.Core.Runtime/Internals/CefImageWrapper.h +++ b/CefSharp.Core.Runtime/Internals/CefImageWrapper.h @@ -21,7 +21,7 @@ namespace CefSharp internal: MCefRefPtr _image; - CefImageWrapper::CefImageWrapper(CefRefPtr &image) + CefImageWrapper(const CefRefPtr &image) : _image(image) { } diff --git a/CefSharp.Core.Runtime/Internals/CefResponseWrapper.h b/CefSharp.Core.Runtime/Internals/CefResponseWrapper.h index d0bcdd752b..a344dc18a1 100644 --- a/CefSharp.Core.Runtime/Internals/CefResponseWrapper.h +++ b/CefSharp.Core.Runtime/Internals/CefResponseWrapper.h @@ -19,7 +19,7 @@ namespace CefSharp { MCefRefPtr _response; internal: - CefResponseWrapper(CefRefPtr &response) : + CefResponseWrapper(const CefRefPtr &response) : _response(response) { diff --git a/CefSharp.Core.Runtime/Internals/CefValueWrapper.h b/CefSharp.Core.Runtime/Internals/CefValueWrapper.h index aa0b667ea7..ea14a59f9e 100644 --- a/CefSharp.Core.Runtime/Internals/CefValueWrapper.h +++ b/CefSharp.Core.Runtime/Internals/CefValueWrapper.h @@ -53,7 +53,7 @@ namespace CefSharp } internal: - CefValueWrapper(CefRefPtr &cefValue) : _cefValue(cefValue) + CefValueWrapper(const CefRefPtr &cefValue) : _cefValue(cefValue) { } diff --git a/CefSharp.Core.Runtime/Internals/StringUtils.h b/CefSharp.Core.Runtime/Internals/StringUtils.h index 3b819c0f80..2ba1467ad7 100644 --- a/CefSharp.Core.Runtime/Internals/StringUtils.h +++ b/CefSharp.Core.Runtime/Internals/StringUtils.h @@ -26,7 +26,7 @@ namespace CefSharp /// The string that should be converted. /// A .NET string. [DebuggerStepThrough] - static String^ StringUtils::ToClr(const cef_string_t& cefStr) + static String^ ToClr(const cef_string_t& cefStr) { auto str = reinterpret_cast(cefStr.str); @@ -39,7 +39,7 @@ namespace CefSharp /// The string that should be converted. /// A .NET string. [DebuggerStepThrough] - static String^ StringUtils::ToClr(const CefString& cefStr) + static String^ ToClr(const CefString& cefStr) { auto str = reinterpret_cast(cefStr.c_str()); @@ -112,7 +112,7 @@ namespace CefSharp /// The cef_string_t that should be updated. /// The .NET string whose value should be used to update cefStr. [DebuggerStepThrough] - static void StringUtils::AssignNativeFromClr(cef_string_t& cefStr, String^ str) + static void AssignNativeFromClr(cef_string_t& cefStr, String^ str) { cef_string_clear(&cefStr); diff --git a/CefSharp.Core.Runtime/RequestContext.h b/CefSharp.Core.Runtime/RequestContext.h index 13e4ddbd83..a46ca63a4a 100644 --- a/CefSharp.Core.Runtime/RequestContext.h +++ b/CefSharp.Core.Runtime/RequestContext.h @@ -42,7 +42,7 @@ namespace CefSharp RequestContextSettings^ _settings; internal: - RequestContext(CefRefPtr& context) + RequestContext(const CefRefPtr& context) { _requestContext = context.get(); _settings = nullptr; diff --git a/CefSharp.Core.Runtime/Stdafx.h b/CefSharp.Core.Runtime/Stdafx.h index 7214f76f35..c234e6e0ef 100644 --- a/CefSharp.Core.Runtime/Stdafx.h +++ b/CefSharp.Core.Runtime/Stdafx.h @@ -10,6 +10,8 @@ #define DECL __declspec(dllimport) #endif +#define NOMINMAX + #include #include