From b4af52db5ab6b2d230f4d0704a1336c8cdc2e42d Mon Sep 17 00:00:00 2001 From: Rajesh Rao Date: Thu, 16 Jul 2026 19:03:07 +0900 Subject: [PATCH 1/2] Fix: sets cmake build type to Release in case it is empty --- CMakeLists.txt | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/CMakeLists.txt b/CMakeLists.txt index 5e6510dfb..ff8e9fa0a 100755 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -2,6 +2,12 @@ cmake_minimum_required (VERSION 3.13) project (brainflow) + +if(NOT CMAKE_BUILD_TYPE AND NOT CMAKE_CONFIGURATION_TYPES) + set(CMAKE_BUILD_TYPE "Release" CACHE STRING "Default build type" FORCE) +endif() + + SET (CMAKE_CXX_STANDARD 11) SET (CMAKE_VERBOSE_MAKEFILE ON) SET (BRAINFLOW_VERSION "0.0.1" CACHE STRING "BrainFlow Version") From d68436c91d0c9ddb016e57ee92b86d7cbf087c6f Mon Sep 17 00:00:00 2001 From: Andrey Parfenov Date: Sun, 2 Aug 2026 21:45:14 +0200 Subject: [PATCH 2/2] Remove libftdi from Android workflow --- .github/workflows/run_android.yml | 20 +------------------- 1 file changed, 1 insertion(+), 19 deletions(-) diff --git a/.github/workflows/run_android.yml b/.github/workflows/run_android.yml index fa61cae75..33236d58c 100644 --- a/.github/workflows/run_android.yml +++ b/.github/workflows/run_android.yml @@ -38,30 +38,12 @@ jobs: echo "y" | sudo -H ${ANDROID_SDK_ROOT}/cmdline-tools/latest/bin/sdkmanager --install "ndk;${ANDROID_NDK_VERSION}" "platforms;${ANDROID_API_LEVEL}" --sdk_root=${ANDROID_SDK_ROOT} env: DEBIAN_FRONTEND: noninteractive - # build for all ABIs - - name: Compile libusb - run: | - git clone --depth 1 --branch android https://github.com/xloem/libusb.git - cd libusb/android/jni - ${ANDROID_HOME}/ndk/${ANDROID_NDK_VERSION}/ndk-build - - name: Compile libftdi - run: | - git clone --depth 1 --branch v1.5 git://developer.intra2net.com/libftdi - cd libftdi - git checkout 5c2c58e03ea999534e8cb64906c8ae8b15536c30 # tip of v1.5 - for ABI in arm64-v8a armeabi-v7a x86 x86_64; do - mkdir $GITHUB_WORKSPACE/libftdi/build-$ABI - cd $GITHUB_WORKSPACE/libftdi/build-$ABI - cmake -G Ninja -DCMAKE_TOOLCHAIN_FILE=${ANDROID_HOME}/ndk/${ANDROID_NDK_VERSION}/build/cmake/android.toolchain.cmake -DANDROID_ABI=$ABI -DCMAKE_BUILD_TYPE=Release -DANDROID_NATIVE_API_LEVEL=${ANDROID_API_LEVEL} -DEXAMPLES=OFF -DFTDI_EEPROM=OFF -DLIBUSB_LIBRARIES=$GITHUB_WORKSPACE/libusb/android/libs/$ABI/libusb1.0.so -DLIBUSB_INCLUDE_DIR=$GITHUB_WORKSPACE/libusb/libusb -DCMAKE_INSTALL_PREFIX=$GITHUB_WORKSPACE/install-$ABI .. - ninja - ninja install - done - name: Compile BrainFlow run: | for ABI in arm64-v8a armeabi-v7a x86 x86_64; do mkdir $GITHUB_WORKSPACE/build-$ABI cd $GITHUB_WORKSPACE/build-$ABI - cmake -G Ninja -DCMAKE_TOOLCHAIN_FILE=${ANDROID_HOME}/ndk/${ANDROID_NDK_VERSION}/build/cmake/android.toolchain.cmake -DANDROID_ABI=$ABI -DCMAKE_BUILD_TYPE=Release -DANDROID_NATIVE_API_LEVEL=${ANDROID_API_LEVEL} -DCMAKE_FIND_ROOT_PATH=$GITHUB_WORKSPACE/install-$ABI -DUSE_LIBFTDI=ON .. + cmake -G Ninja -DCMAKE_TOOLCHAIN_FILE=${ANDROID_HOME}/ndk/${ANDROID_NDK_VERSION}/build/cmake/android.toolchain.cmake -DANDROID_ABI=$ABI -DCMAKE_BUILD_TYPE=Release -DANDROID_NATIVE_API_LEVEL=${ANDROID_API_LEVEL} .. ninja done - name: Build Android AAR