From 989e8b258063ffa820f9b9fbbaff57e1449cb1aa Mon Sep 17 00:00:00 2001 From: Hersha Venkatesh Date: Mon, 17 Oct 2022 11:56:47 -0700 Subject: [PATCH] fix(preview-sidebar): fix version not updating on small screens --- .../versions/VersionsSidebarContainer.js | 5 ----- .../__tests__/VersionsSidebarContainer.test.js | 11 ----------- 2 files changed, 16 deletions(-) diff --git a/src/elements/content-sidebar/versions/VersionsSidebarContainer.js b/src/elements/content-sidebar/versions/VersionsSidebarContainer.js index 175a773d11..c8d7596a95 100644 --- a/src/elements/content-sidebar/versions/VersionsSidebarContainer.js +++ b/src/elements/content-sidebar/versions/VersionsSidebarContainer.js @@ -95,11 +95,6 @@ class VersionsSidebarContainer extends React.Component { } } - componentWillUnmount() { - // Reset the current version id since the wrapping route is no longer active - this.props.onVersionChange(null); - } - handleActionDelete = (versionId: string): Promise => { this.setState({ isLoading: true }); diff --git a/src/elements/content-sidebar/versions/__tests__/VersionsSidebarContainer.test.js b/src/elements/content-sidebar/versions/__tests__/VersionsSidebarContainer.test.js index 6d7f2c26d5..6178d9efad 100644 --- a/src/elements/content-sidebar/versions/__tests__/VersionsSidebarContainer.test.js +++ b/src/elements/content-sidebar/versions/__tests__/VersionsSidebarContainer.test.js @@ -58,17 +58,6 @@ describe('elements/content-sidebar/versions/VersionsSidebarContainer', () => { }); }); - describe('componentWillUnmount', () => { - test('should forward verison id reset to the parent component', () => { - const onVersionChange = jest.fn(); - const wrapper = getWrapper({ onVersionChange }); - - wrapper.instance().componentWillUnmount(); - - expect(onVersionChange).toBeCalledWith(null); - }); - }); - describe('componentDidMount', () => { test('should call onLoad after a successful fetchData() call', async () => { const onLoad = jest.fn();