From b709a3cdef227e26c892f2864c27d59d997915a6 Mon Sep 17 00:00:00 2001 From: bootc-dev Bot Date: Mon, 11 May 2026 04:53:46 +0000 Subject: [PATCH] Sync common files from infra repository Synchronized from bootc-dev/infra@ff66c1c724faeb83b5cd2af36d9a5d2129ecf95a. Signed-off-by: bootc-dev Bot --- .bootc-dev-infra-commit.txt | 2 +- .cursorrules | 1 + REVIEW.md | 14 ++++++++++++++ 3 files changed, 16 insertions(+), 1 deletion(-) create mode 120000 .cursorrules diff --git a/.bootc-dev-infra-commit.txt b/.bootc-dev-infra-commit.txt index 0c9344b..47dceb5 100644 --- a/.bootc-dev-infra-commit.txt +++ b/.bootc-dev-infra-commit.txt @@ -1 +1 @@ -fb9e91b161adacd1c0e9144a76b64159c482b92e +ff66c1c724faeb83b5cd2af36d9a5d2129ecf95a diff --git a/.cursorrules b/.cursorrules new file mode 120000 index 0000000..47dc3e3 --- /dev/null +++ b/.cursorrules @@ -0,0 +1 @@ +AGENTS.md \ No newline at end of file diff --git a/REVIEW.md b/REVIEW.md index f9ee4d5..3c1d690 100644 --- a/REVIEW.md +++ b/REVIEW.md @@ -139,6 +139,20 @@ Generally, just restate the commit message. Where it makes sense, it is OK to include additional details though. +### Further changes on top of existing commits + +If you have followup fixes (whether that's part of a local loop or +as part of addressing PR review), it is generally encouraged to *squash* +the fixes into the prior commit. Do not create generically-named "Update " commits +or "Address review feedback" or "Fix cargo fmt" commits. + +This applies equally when an AI tool (e.g. Gemini, Copilot) suggests a +change via a review comment — applying the suggestion creates a new commit +with an auto-generated subject. That commit should be squashed before the +PR is merged. + +In other words either a commit "stands alone" with its own rationale or it doesn't. + ### Keeping PRs Current Keep PRs rebased on main. When CI failures are fixed in other PRs, rebase to