From 4a17884210b134b5ad306d1dc51e5222341b5dd7 Mon Sep 17 00:00:00 2001 From: Stephen G Tuggy Date: Sat, 27 Jun 2026 07:14:45 -0700 Subject: [PATCH 1/6] test-windows.yml: Exit workflow on any errors during the build or test phases --- .github/workflows/test-windows.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/test-windows.yml b/.github/workflows/test-windows.yml index d13b6bf86..eca2e3b1d 100644 --- a/.github/workflows/test-windows.yml +++ b/.github/workflows/test-windows.yml @@ -67,11 +67,13 @@ jobs: shell: cmd run: | faber --builddir=build cxx.name=msvc --log=commands --log=output --with-boost-include="${{ github.workspace }}/vcpkgInstalled/x64-windows/include" -j4 + if %errorlevel% neq 0 exit %errorlevel% - name: test shell: cmd run: | faber --builddir=build cxx.name=msvc --with-boost-include="${{ github.workspace }}/vcpkgInstalled/x64-windows/include" -j4 test.report + if %errorlevel% neq 0 exit %errorlevel% - name: Save vcpkg cache id: cache-vcpkg-save From 8c19e0d1aec187f72722acb4decac335093e00a8 Mon Sep 17 00:00:00 2001 From: Stephen G Tuggy Date: Sat, 27 Jun 2026 15:45:17 +0000 Subject: [PATCH 2/6] test-windows.yml: Try switching to PowerShell as the shell, instead of cmd --- .github/workflows/test-windows.yml | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/.github/workflows/test-windows.yml b/.github/workflows/test-windows.yml index eca2e3b1d..75a95a041 100644 --- a/.github/workflows/test-windows.yml +++ b/.github/workflows/test-windows.yml @@ -64,16 +64,14 @@ jobs: faber --info=tools cxx - name: build - shell: cmd + shell: pwsh run: | faber --builddir=build cxx.name=msvc --log=commands --log=output --with-boost-include="${{ github.workspace }}/vcpkgInstalled/x64-windows/include" -j4 - if %errorlevel% neq 0 exit %errorlevel% - name: test - shell: cmd + shell: pwsh run: | faber --builddir=build cxx.name=msvc --with-boost-include="${{ github.workspace }}/vcpkgInstalled/x64-windows/include" -j4 test.report - if %errorlevel% neq 0 exit %errorlevel% - name: Save vcpkg cache id: cache-vcpkg-save From 77c721b93f32297e055ee72537cddf26116cb040 Mon Sep 17 00:00:00 2001 From: Stephen G Tuggy Date: Sat, 27 Jun 2026 10:10:59 -0700 Subject: [PATCH 3/6] test-windows.yml: Try to fix caching --- .github/workflows/test-windows.yml | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/.github/workflows/test-windows.yml b/.github/workflows/test-windows.yml index 75a95a041..e6856bf30 100644 --- a/.github/workflows/test-windows.yml +++ b/.github/workflows/test-windows.yml @@ -29,18 +29,18 @@ jobs: uses: actions/cache/restore@27d5ce7f107fe9357f9df03efb73ab90386fccae # v5.0.5 with: path: | - "${{ github.workspace }}/vcpkgAssets" - "${{ github.workspace }}/vcpkgBCache" - "${{ github.workspace }}/vcpkgBin" - "${{ github.workspace }}/vcpkgBuild" - key: vcpkgCache-${{ github.repository_owner }}-${{ matrix.os }}-${{ matrix.triplet }}-${{ hashFiles('vcpkg.json') }} + "${{ github.workspace }}\\vcpkgAssets" + "${{ github.workspace }}\\vcpkgBCache" + "${{ github.workspace }}\\vcpkgBin" + "${{ github.workspace }}\\vcpkgBuild" + key: vcpkgCache-${{ github.repository_owner }}-windows-latest-x64-windows-${{ hashFiles('.github/workflows/vcpkg.json') }} - name: Create directories on cache miss run: | - mkdir -p "${{ github.workspace }}/vcpkgAssets" - mkdir -p "${{ github.workspace }}/vcpkgBCache" - mkdir -p "${{ github.workspace }}/vcpkgBin" - mkdir -p "${{ github.workspace }}/vcpkgBuild" + New-Item -Force -ItemType Directory -Path "${{ github.workspace }}\\vcpkgAssets" + New-Item -Force -ItemType Directory -Path "${{ github.workspace }}\\vcpkgBCache" + New-Item -Force -ItemType Directory -Path "${{ github.workspace }}\\vcpkgBin" + New-Item -Force -ItemType Directory -Path "${{ github.workspace }}\\vcpkgBuild" if: steps.cache-vcpkg-restore.outputs.cache-hit != 'true' - uses: actions/setup-python@v6 @@ -78,9 +78,9 @@ jobs: uses: actions/cache/save@27d5ce7f107fe9357f9df03efb73ab90386fccae # v5.0.5 with: path: | - "${{ github.workspace }}/vcpkgAssets" - "${{ github.workspace }}/vcpkgBCache" - "${{ github.workspace }}/vcpkgBin" - "${{ github.workspace }}/vcpkgBuild" + "${{ github.workspace }}\\vcpkgAssets" + "${{ github.workspace }}\\vcpkgBCache" + "${{ github.workspace }}\\vcpkgBin" + "${{ github.workspace }}\\vcpkgBuild" key: ${{ steps.cache-vcpkg-restore.outputs.cache-primary-key }} if: steps.cache-vcpkg-restore.outputs.cache-hit != 'true' From c4b4dce957f4efff0f5166746c933f55d504082f Mon Sep 17 00:00:00 2001 From: Stephen G Tuggy Date: Sat, 27 Jun 2026 10:22:04 -0700 Subject: [PATCH 4/6] test-windows.yml: Try to fix caching, continued -- make sure to run the `New-Item` commands with the right shell (PowerShell) --- .github/workflows/test-windows.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/test-windows.yml b/.github/workflows/test-windows.yml index e6856bf30..a0fa4d33c 100644 --- a/.github/workflows/test-windows.yml +++ b/.github/workflows/test-windows.yml @@ -41,6 +41,7 @@ jobs: New-Item -Force -ItemType Directory -Path "${{ github.workspace }}\\vcpkgBCache" New-Item -Force -ItemType Directory -Path "${{ github.workspace }}\\vcpkgBin" New-Item -Force -ItemType Directory -Path "${{ github.workspace }}\\vcpkgBuild" + shell: pwsh if: steps.cache-vcpkg-restore.outputs.cache-hit != 'true' - uses: actions/setup-python@v6 From 63edff78079900c4d792c664b80a044a89cdc8cf Mon Sep 17 00:00:00 2001 From: Stephen G Tuggy Date: Sat, 27 Jun 2026 11:00:50 -0700 Subject: [PATCH 5/6] test-windows.yml: Try to fix caching, continued -- single backslashes rather than two in a row --- .github/workflows/test-windows.yml | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/.github/workflows/test-windows.yml b/.github/workflows/test-windows.yml index a0fa4d33c..5e4ff9e29 100644 --- a/.github/workflows/test-windows.yml +++ b/.github/workflows/test-windows.yml @@ -29,18 +29,18 @@ jobs: uses: actions/cache/restore@27d5ce7f107fe9357f9df03efb73ab90386fccae # v5.0.5 with: path: | - "${{ github.workspace }}\\vcpkgAssets" - "${{ github.workspace }}\\vcpkgBCache" - "${{ github.workspace }}\\vcpkgBin" - "${{ github.workspace }}\\vcpkgBuild" + "${{ github.workspace }}\vcpkgAssets" + "${{ github.workspace }}\vcpkgBCache" + "${{ github.workspace }}\vcpkgBin" + "${{ github.workspace }}\vcpkgBuild" key: vcpkgCache-${{ github.repository_owner }}-windows-latest-x64-windows-${{ hashFiles('.github/workflows/vcpkg.json') }} - name: Create directories on cache miss run: | - New-Item -Force -ItemType Directory -Path "${{ github.workspace }}\\vcpkgAssets" - New-Item -Force -ItemType Directory -Path "${{ github.workspace }}\\vcpkgBCache" - New-Item -Force -ItemType Directory -Path "${{ github.workspace }}\\vcpkgBin" - New-Item -Force -ItemType Directory -Path "${{ github.workspace }}\\vcpkgBuild" + New-Item -Force -ItemType Directory -Path "${{ github.workspace }}\vcpkgAssets" + New-Item -Force -ItemType Directory -Path "${{ github.workspace }}\vcpkgBCache" + New-Item -Force -ItemType Directory -Path "${{ github.workspace }}\vcpkgBin" + New-Item -Force -ItemType Directory -Path "${{ github.workspace }}\vcpkgBuild" shell: pwsh if: steps.cache-vcpkg-restore.outputs.cache-hit != 'true' @@ -79,9 +79,9 @@ jobs: uses: actions/cache/save@27d5ce7f107fe9357f9df03efb73ab90386fccae # v5.0.5 with: path: | - "${{ github.workspace }}\\vcpkgAssets" - "${{ github.workspace }}\\vcpkgBCache" - "${{ github.workspace }}\\vcpkgBin" - "${{ github.workspace }}\\vcpkgBuild" + "${{ github.workspace }}\vcpkgAssets" + "${{ github.workspace }}\vcpkgBCache" + "${{ github.workspace }}\vcpkgBin" + "${{ github.workspace }}\vcpkgBuild" key: ${{ steps.cache-vcpkg-restore.outputs.cache-primary-key }} if: steps.cache-vcpkg-restore.outputs.cache-hit != 'true' From 5fd97205c5cb62a36562250a221e7d518f56190f Mon Sep 17 00:00:00 2001 From: Stephen G Tuggy Date: Sun, 28 Jun 2026 12:32:04 -0700 Subject: [PATCH 6/6] test-windows.yml: Try to fix caching, continued -- remove quotes --- .github/workflows/test-windows.yml | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/.github/workflows/test-windows.yml b/.github/workflows/test-windows.yml index 5e4ff9e29..2649b4a4e 100644 --- a/.github/workflows/test-windows.yml +++ b/.github/workflows/test-windows.yml @@ -29,10 +29,10 @@ jobs: uses: actions/cache/restore@27d5ce7f107fe9357f9df03efb73ab90386fccae # v5.0.5 with: path: | - "${{ github.workspace }}\vcpkgAssets" - "${{ github.workspace }}\vcpkgBCache" - "${{ github.workspace }}\vcpkgBin" - "${{ github.workspace }}\vcpkgBuild" + ${{ github.workspace }}\vcpkgAssets + ${{ github.workspace }}\vcpkgBCache + ${{ github.workspace }}\vcpkgBin + ${{ github.workspace }}\vcpkgBuild key: vcpkgCache-${{ github.repository_owner }}-windows-latest-x64-windows-${{ hashFiles('.github/workflows/vcpkg.json') }} - name: Create directories on cache miss @@ -79,9 +79,9 @@ jobs: uses: actions/cache/save@27d5ce7f107fe9357f9df03efb73ab90386fccae # v5.0.5 with: path: | - "${{ github.workspace }}\vcpkgAssets" - "${{ github.workspace }}\vcpkgBCache" - "${{ github.workspace }}\vcpkgBin" - "${{ github.workspace }}\vcpkgBuild" + ${{ github.workspace }}\vcpkgAssets + ${{ github.workspace }}\vcpkgBCache + ${{ github.workspace }}\vcpkgBin + ${{ github.workspace }}\vcpkgBuild key: ${{ steps.cache-vcpkg-restore.outputs.cache-primary-key }} if: steps.cache-vcpkg-restore.outputs.cache-hit != 'true'