test262 conformance github actions bot should also include commit hash of the tested version

[zhuzhu81998]

Current message from the actions bot in PRs looks like this:

which is fine if you only push once and it is unambiguous which commit is tested under PR count.

However, it gets a bit confusing if you push changes multiple times, because the bot will update the original comment instead of making a new one. Then it is not immediately clear, which test result is for which commit.

It should be a fairly simple task to include github.event.pull_request.head.sha in the comment. I would raise a PR myself, but I cant actually test it properly since I have no permission to trigger actions XD

[jedel1043]

Actually, you can test it in your own fork :)
That's how I tested the migration to pull_request_target

[jedel1043]

So just open the PR and link the results of your test in your own fork, then we can double check that everything looks correct

[zhuzhu81998]

ideally, in addition to #4765 , also the commit hash of the main branch should be added.

I notice the current results for the main branch are calculated on a daily basis in another repo by https://github.com/boa-dev/data/blob/main/.github/workflows/test262.yml ?

Does something speak against putting the action in the boa repo and have it be triggered by push: branch: main ? This way, you can save the commit hash and be able to compare prs with an up-to-date version of main instead of last day midnight.

[zhuzhu81998]

@jedel1043 do you see a problem with the idea above( #4760 (comment)) ?

[jedel1043]

Not against the idea, but we didn't do it at the time because we had to somehow trigger an action on the data repository from here (or at least push a commit to that repo from here) and it was more complex than expected.

Though, this was a long time ago, so Github might have an easier way to do that now.

[jedel1043]

Opened #4792