-
Notifications
You must be signed in to change notification settings - Fork 438
Open
Labels
github_actionsPull requests that update GitHub Actions codePull requests that update GitHub Actions code
Description
Currently cargo doc --workspace --no-deps throws warnings for some of our workspace packages, for example due to redundant_explicit_links and broken_intra_doc_links. To prevent documentation errors from persisting consider adding a CI job to check building the docs for each package.
Tasks
- Add
ci/check-docs.shscript that runscargo rustdocfor each package in the workspace. The script should fail if any cargo rustdoc invocations produce warnings - Add a
check-docsjob tocont_integration.ymlthat calls the check-docs.sh script - Add a justfile recipe
just docthat similarly executes check-docs.sh
Alternatively, use a 1-liner somewhere in cont_integration.yml (e.g. in build-test) such as
RUSTDOCFLAGS='-D warnings' cargo doc --workspace --no-deps
however that's not as explicit as it could be with respect to the crate names.
Build environment
- BDK tag/commit: fb05873
- OS+version:
- Rust/Cargo version: 1.93.1
- Rust/Cargo target:
Which backend(s) are relevant (if any)?
- Electrum
- Esplora
- Bitcoin Core RPC
- None / not backend-related (e.g.
bdk_chain,bdk_core) - Other (please specify):
____
Is this blocking production use?
- Yes
- No
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
github_actionsPull requests that update GitHub Actions codePull requests that update GitHub Actions code
Type
Projects
Status
No status
Status
Todo