From 1588f61fc3cf06cad99f2f1d2eac9d06f1fe8baa Mon Sep 17 00:00:00 2001 From: Kaiyi Li Date: Wed, 3 Jun 2026 15:10:34 +0000 Subject: [PATCH] android_feature_module: use package_relative_label to resolve target paths Those targets are defined relative to where the macro is used, not where macro is defined. Therefore, change `Label` to `native.package_relative_label`. --- rules/android_application/android_feature_module_rule.bzl | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/rules/android_application/android_feature_module_rule.bzl b/rules/android_application/android_feature_module_rule.bzl index f4b240571..2b5600826 100644 --- a/rules/android_application/android_feature_module_rule.bzl +++ b/rules/android_application/android_feature_module_rule.bzl @@ -95,10 +95,10 @@ def get_feature_module_paths(fqn): # Given a fqn to an android_feature_module, returns the absolute paths to # all implicitly generated targets return struct( - binary = Label("%s_bin" % fqn), - manifest_lib = Label("%s_AndroidManifest" % fqn), - title_strings_xml = Label("%s_title_strings_xml" % fqn), - title_lib = Label("%s_title_lib" % fqn), + binary = native.package_relative_label("%s_bin" % fqn), + manifest_lib = native.package_relative_label("%s_AndroidManifest" % fqn), + title_strings_xml = native.package_relative_label("%s_title_strings_xml" % fqn), + title_lib = native.package_relative_label("%s_title_lib" % fqn), ) def android_feature_module_macro(_android_binary, _android_library, **attrs):