Dynamic suggestions containing blank or single quote

[thomas-maeder]

If the dynamic suggestions contain blanks or single quotes, they appear garbled after I hit Tab-Tab.

I can work around this by escaping the 2 characters using something like: sed --expression=$'s/([ '])/\\\1/g'

It would be nice if completely would take care of this.

[DannyBen]

Confirmed bug. I am now attempting a fix.

[DannyBen]

This is fixed in #97
If you have a way to test it for your use case before I merge, it will help.

[thomas-maeder]

Hmm - I'd be glad to help, but I don't really know how.
I did gem install completely to be able to use completely.
How can I activate the result of #97?

[DannyBen]

Oh good - if you have Ruby, it is easy:

# clone the repo and cd to it
git clone https://github.com/bashly-framework/completely.git
cd ./completely

# ensure all ruby dependencies exist (including dev deps)
bundle install

# install the gem from development
bundle exec run gem install

only if its not too much trouble. If you don't feel comfortable running these, then don't worry about it.

[thomas-maeder]

I also had to install ruby-dev and libyaml-dev for psych.

Let's see:

$ type completely
completely is hashed (/usr/local/bin/completely)

$ ls -l /usr/local/bin/completely
-rwxr-xr-x 1 root root 566 Feb 18 22:10 /usr/local/bin/completely

$ completely --version
0.7.3

But the list of options produced by tab-tab is still garbled.
The option where things start to look ugly contains blanks and parentheses.

[thomas-maeder]

If I compare my script (with the sed workaround) and the one I have got from this 0.7.3 version, I only see my workaround. Obviously, your additions aren't active at my end.

`$ diff completely.bash ~/.bash_completion.d/bw
126c126
< while read -r; do COMPREPLY+=("$REPLY"); done < <(compgen -W "$(_bw_completions_filter "$(bw list org-collections | jq --raw-output '.[] | .name')")" -- "$cur")

  while read -r; do COMPREPLY+=("$REPLY"); done < <(compgen -W "$(_bw_completions_filter "$(bw list org-collections | jq --raw-output '.[] | .name' | sed --regexp-extended --expression=$'s/([ \'])/\\\\\\1/g')")" -- "$cur")

158c158
< while read -r; do COMPREPLY+=("$REPLY"); done < <(compgen -W "$(_bw_completions_filter "$(bw list organizations | jq --raw-output '.[] | .name')")" -- "$cur")

  while read -r; do COMPREPLY+=("$REPLY"); done < <(compgen -W "$(_bw_completions_filter "$(bw list organizations | jq --raw-output '.[] | .name' | sed --regexp-extended --expression=$'s/([ \'])/\\\\\\1/g')")" -- "$cur")

166c166
< while read -r; do COMPREPLY+=("$REPLY"); done < <(compgen -W "$(_bw_completions_filter "$(bw list collections | jq --raw-output '.[] | .name')")" -- "$cur")

  while read -r; do COMPREPLY+=("$REPLY"); done < <(compgen -W "$(_bw_completions_filter "$(bw list collections | jq --raw-output '.[] | .name' | sed --regexp-extended --expression=$'s/([ \'])/\\\\\\1/g')")" -- "$cur")

190c190
< while read -r; do COMPREPLY+=("$REPLY"); done < <(compgen -W "$(_bw_completions_filter "$(bw list folders | jq --raw-output '.[] | .name')")" -- "$cur")

  while read -r; do COMPREPLY+=("$REPLY"); done < <(compgen -W "$(_bw_completions_filter "$(bw list folders | jq --raw-output '.[] | .name' | sed --regexp-extended --expression=$'s/([ \'])/\\\\\\1/g')")" -- "$cur")

206c206
< while read -r; do COMPREPLY+=("$REPLY"); done < <(compgen -W "$(_bw_completions_filter "$(bw list items | jq --raw-output '.[] | .name')")" -- "$cur")

  while read -r; do COMPREPLY+=("$REPLY"); done < <(compgen -W "$(_bw_completions_filter "$(bw list items | jq --raw-output '.[] | .name' | sed --regexp-extended --expression=$'s/([ \'])/\\\\\\1/g')")" -- "$cur")

`

[DannyBen]

The completely gem version would still be the same.

I think I forgot to give you one step - to checkout to the PR branch.

git checkout fix/escaping

then bundle exec run gem install again.

You should see the change clearly in the generated bash script - no need for diff.

[thomas-maeder]

Sorry, I'm giving up.
I don't know anything about this ruby world, and I'm afraid of messing my system up.

[DannyBen]

No worries, thanks for trying and for the report.
I believe it is fixed - I will soon release.

[DannyBen]

Fixed and released in version 0.7.4.

[thomas-maeder]

I have just installed 0.7.4.
Sorry to say it, but it doesn't solve the issue at all.
Everything is still garbled. Differently than from 0.7.3, but still very garbled.

0.7.3 with | sed --regexp-extended --expression=$'s/([ \'])/\\\\\\1/g' gives me the correct completions, so I stick with this for the time being.

FWIW: 0.7.4 gives me sed: -e Ausdruck #1, Zeichen 7: Nicht beendeter »s«-Befehl (~ unterminated command s) when I use the workaround and hit tab-tab.

[DannyBen]

Paste the simplest YAML that reproduces the issue.