From 7878214efe2c8dfd31737b79432aeab1267b83b8 Mon Sep 17 00:00:00 2001 From: Rakshil Modi Date: Fri, 26 Jun 2026 09:50:27 -0700 Subject: [PATCH 1/2] Prevent script injection in GHA workflows --- .github/workflows/issue-regression-labeler.yml | 9 ++++++--- .github/workflows/release.yml | 3 ++- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/.github/workflows/issue-regression-labeler.yml b/.github/workflows/issue-regression-labeler.yml index bd000719..f98347d2 100644 --- a/.github/workflows/issue-regression-labeler.yml +++ b/.github/workflows/issue-regression-labeler.yml @@ -24,9 +24,12 @@ jobs: - name: Manage regression label env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} + IS_REGRESSION: ${{ steps.check_regression.outputs.is_regression }} + ISSUE_NUMBER: ${{ github.event.issue.number }} + REPO: ${{ github.repository }} run: | - if [ "${{ steps.check_regression.outputs.is_regression }}" == "true" ]; then - gh issue edit ${{ github.event.issue.number }} --add-label "potential-regression" -R ${{ github.repository }} + if [ "$IS_REGRESSION" == "true" ]; then + gh issue edit "$ISSUE_NUMBER" --add-label "potential-regression" -R "$REPO" else - gh issue edit ${{ github.event.issue.number }} --remove-label "potential-regression" -R ${{ github.repository }} + gh issue edit "$ISSUE_NUMBER" --remove-label "potential-regression" -R "$REPO" fi diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 5d79edd1..bb374fdd 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -34,13 +34,14 @@ jobs: - name: Make new release env: Title: ${{ github.event.inputs.release_title }} + ReleaseType: ${{ github.event.inputs.release_type }} run: | # Escape special characters Title=$(echo ${Title//[\"]\\\"}) Title=$(echo ${Title//[\']\\\'}) Title=$(echo ${Title//[\$]}) - ./utils/publish-release.sh "${{ github.event.inputs.release_type }}" "$Title" + ./utils/publish-release.sh "$ReleaseType" "$Title" - name: Generate documentation run: | From de37139e62c0ea0ca0340de2880f8c5550ebe41b Mon Sep 17 00:00:00 2001 From: Rakshil Modi Date: Mon, 29 Jun 2026 10:41:08 -0700 Subject: [PATCH 2/2] Changing env to caps --- .github/workflows/release.yml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index bb374fdd..b2fe6fd8 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -33,15 +33,15 @@ jobs: - name: Make new release env: - Title: ${{ github.event.inputs.release_title }} - ReleaseType: ${{ github.event.inputs.release_type }} + TITLE: ${{ github.event.inputs.release_title }} + RELEASE_TYPE: ${{ github.event.inputs.release_type }} run: | # Escape special characters - Title=$(echo ${Title//[\"]\\\"}) - Title=$(echo ${Title//[\']\\\'}) - Title=$(echo ${Title//[\$]}) + TITLE=$(echo ${TITLE//[\"]\\\"}) + TITLE=$(echo ${TITLE//[\']\\\'}) + TITLE=$(echo ${TITLE//[\$]}) - ./utils/publish-release.sh "$ReleaseType" "$Title" + ./utils/publish-release.sh "$RELEASE_TYPE" "$TITLE" - name: Generate documentation run: |