Skip to content

Owner filter offers the wrong people on unified search and on the Hub #8385

Description

@tanishqgandhi1908

What happened?

The Owner filter is shared by five pages (unified search, the three Your Work pages, and the hub) and it asks the wrong question on two of them. Both bugs are in the same dropdown, so they are filed together.

1. Unified search never tells the filter which tab you are on.

search.component.html:80 renders <texera-filters #filters></texera-filters> with no [entityType], so the bar keeps its default of EntityType.Workflow on every tab. The Owner dropdown therefore lists workflow owners on the Datasets tab, the Models tab and the All tab. Tick someone who owns workflows but no datasets and the Datasets tab empties out with no explanation. The tab buttons set selectedType and never pass it to the bar.

2. The hub offers owners drawn from your private access list, not from what the hub shows.

The hub browses public resources, but all three owner endpoints filter on the caller's own access rows. So the dropdown lists people whose resources are not on the page, and omits the people whose resources are.

Expected: the dropdown offers exactly the owners whose resources the current page can show.

What is not broken, so the fix stays narrow:

  • The filtering itself is correct. Every resource arm applies the owner predicate against its own owners (WorkflowSearchQueryBuilder:115, VersionedResourceSearchQueryBuilder:126), so an owner picked on the All tab correctly means "their workflows, datasets and models". Only the list of names offered is wrong.
  • The Your Work → Workflows, Datasets and Models pages are correct — they bind [entityType] and read their own access-scoped endpoints, which is exactly right for a page listing what you can see. fix(frontend, amber): source filter owners per resource kind and apply them to datasets #8060 fixed those.
  • Logged-out visitors see no Owner dropdown at all, and that stays. The list is made of email addresses, so it should not be served to anonymous visitors.

Screenshots

Unified search, Model tab — the Owner dropdown lists workflow owners:

Image

Ticking one of them empties the tab:

Image

Hub → Datasets as bob — the one result is owned by texera, but bob is offered as an owner:

Image

Ticking bob empties the hub:

Image

How to reproduce?

Both were reproduced on a local stack. texera owns 2 workflows, 3 datasets and 3 models; bob owns 1 workflow and 1 private dataset, and no models.

Bug 1 — unified search, Model tab:

  1. Sign in as texera and open the unified search page (/search).
  2. Switch to the Model tab. One model is listed (empty-model).
  3. Open the Owner dropdown: it offers texera and bob@test.com. Those are the workflow owners
    bob owns no model at all.
  4. Tick bob@test.com. The Model tab goes empty.

Version/Branch

1.4.0-incubating-SNAPSHOT (main)

Commit Hash (Optional)

No response

What browsers are you seeing the problem on?

No response

Relevant log output

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

No labels
No labels

Type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions