From 36d14490c1ea2ac34acafa2a0276d0afc99d9ad4 Mon Sep 17 00:00:00 2001 From: "Piotr P. Karwasz" Date: Wed, 11 Nov 2026 22:57:16 +0100 Subject: [PATCH] test: enable TCP_NODELAY in SslEnd2EndTest `SslEnd2EndTest` performs 8192 small echo round trips. Without `TCP_NODELAY`, Nagle's algorithm interacts with Linux delayed ACKs and adds about 80 ms to each round trip, so the test takes about 11 minutes on Ubuntu CI runners versus 9 seconds on Windows. With `TCP_NODELAY` it completes in about 4 seconds on Linux. Assisted-By: Claude Opus 5.5 --- .../test/java/org/apache/mina/filter/ssl/SslEnd2EndTest.java | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/mina-core/src/test/java/org/apache/mina/filter/ssl/SslEnd2EndTest.java b/mina-core/src/test/java/org/apache/mina/filter/ssl/SslEnd2EndTest.java index 8f4d95927..3501e8e90 100644 --- a/mina-core/src/test/java/org/apache/mina/filter/ssl/SslEnd2EndTest.java +++ b/mina-core/src/test/java/org/apache/mina/filter/ssl/SslEnd2EndTest.java @@ -181,6 +181,8 @@ private void assertNoException(Throwable exception) { private IoAcceptor createAcceptor(IoHandler handler) throws Exception { NioSocketAcceptor acceptor = new NioSocketAcceptor(); acceptor.setReuseAddress(true); + // Disable Nagle's algorithm: combined with delayed ACKs, it adds ~40 ms per round trip on Linux. + acceptor.getSessionConfig().setTcpNoDelay(true); acceptor.setHandler(handler); DefaultIoFilterChainBuilder filters = acceptor.getFilterChain(); @@ -199,6 +201,8 @@ private IoAcceptor createAcceptor(IoHandler handler) throws Exception { private IoConnector createConnector(IoHandler ioHandler) throws GeneralSecurityException, IOException { NioSocketConnector connector = new NioSocketConnector(); + // See createAcceptor(). + connector.getSessionConfig().setTcpNoDelay(true); connector.setHandler(ioHandler); DefaultIoFilterChainBuilder filters = connector.getFilterChain();