From ddfb3c281b0e8af78314f8e930f7cee67524d714 Mon Sep 17 00:00:00 2001
From: JackieTien97 <jackietien97@gmail.com>
Date: Sun, 17 May 2026 15:51:50 +0800
Subject: [PATCH] Remove dead surefire executions in root pom
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The root pom declared two extra surefire executions, `unit-tests` (bound to
the `test` phase) and `integration-tests` (bound to the `integration-test`
phase), each with an `<includes>` pattern prefixed by `src/test/`:

    <includes><include>src/test/**/*Test.java</include></includes>

Surefire scans `${project.build.testOutputDirectory}` (target/test-classes/)
for compiled tests and matches `<includes>` against paths relative to that
directory. Those paths never start with `src/test/`, so both executions match
zero tests on every build — verified against the latest master Unit-Test run
(job 76358113571): each completes in <1 second with no test output.

The TODO comment above the plugin already noted that integration tests should
move to the failsafe plugin. That's now the case: both modules containing
`*IT.java` (`iotdb-core/datanode/` and `integration-test/`) have explicit
`maven-failsafe-plugin` configurations driving their ITs. Removing these two
dead executions therefore changes nothing observable on master — same set of
tests, same wall clock — and eliminates a hidden trap: anyone passing a
surefire CLI flag like `-Dsurefire.includesFile=` or `-Dtest=` would
otherwise discover that the broken `<includes>` gets replaced by their valid
selector, accidentally activating the previously-dormant executions and
running the chosen tests three times instead of once.

Regression checked:
  - Only `iotdb-core/datanode/pom.xml` and `integration-test/pom.xml` contain
    `*IT.java`; both configure failsafe directly.
  - No other module-level pom redeclares an execution with id `unit-tests`
    or `integration-tests`.
  - No CI workflow passes a surefire test-selector flag that would have
    been affected.
  - The `with-code-coverage` profile only overrides the `<argLine>` for
    surefire/failsafe; it does not depend on these executions.
---
 pom.xml | 42 ------------------------------------------
 1 file changed, 42 deletions(-)

diff --git a/pom.xml b/pom.xml
index 6fad8ff9407f0..c960a8d447669 100644
--- a/pom.xml
+++ b/pom.xml
@@ -1301,48 +1301,6 @@
                     </execution>
                 </executions>
             </plugin>
-            <!-- Separates the unit tests from the integration tests. -->
-            <!-- TODO: Integration-Tests should be executed by the failsafe plugin -->
-            <plugin>
-                <groupId>org.apache.maven.plugins</groupId>
-                <artifactId>maven-surefire-plugin</artifactId>
-                <executions>
-                    <execution>
-                        <id>unit-tests</id>
-                        <goals>
-                            <goal>test</goal>
-                        </goals>
-                        <phase>test</phase>
-                        <configuration>
-                            <includes>
-                                <!-- Include unit tests within integration-test phase. -->
-                                <include>src/test/**/*Test.java</include>
-                            </includes>
-                            <excludes>
-                                <!-- Exclude integration tests within (unit) test phase. -->
-                                <exclude>src/test/**/*IT.java</exclude>
-                            </excludes>
-                        </configuration>
-                    </execution>
-                    <execution>
-                        <id>integration-tests</id>
-                        <goals>
-                            <goal>test</goal>
-                        </goals>
-                        <phase>integration-test</phase>
-                        <configuration>
-                            <includes>
-                                <!-- Include integration tests within integration-test phase. -->
-                                <include>src/test/**/*IT.java</include>
-                            </includes>
-                            <excludes>
-                                <!-- Exclude unit tests within (unit) test phase. -->
-                                <exclude>src/test/**/*Test.java</exclude>
-                            </excludes>
-                        </configuration>
-                    </execution>
-                </executions>
-            </plugin>
             <!-- Also package the sources as jar -->
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>