From c98ae53da1003f667ae120abbaa28c1877724a40 Mon Sep 17 00:00:00 2001 From: Ratul Dawar Date: Sun, 1 Mar 2026 15:38:47 +0530 Subject: [PATCH 1/2] Fix FileStream scanning_total to include sync next-file open time --- datafusion/datasource/src/file_stream.rs | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/datafusion/datasource/src/file_stream.rs b/datafusion/datasource/src/file_stream.rs index c8090382094ef..6f450f47df833 100644 --- a/datafusion/datasource/src/file_stream.rs +++ b/datafusion/datasource/src/file_stream.rs @@ -126,7 +126,12 @@ impl FileStream { Ok(reader) => { // include time needed to start opening in `start_next_file` self.file_stream_metrics.time_opening.stop(); - let next = self.start_next_file().transpose(); + let next = { + let scanning_total_metric = + self.file_stream_metrics.time_scanning_total.metrics.clone(); + let _timer = scanning_total_metric.timer(); + self.start_next_file().transpose() + }; self.file_stream_metrics.time_scanning_until_data.start(); self.file_stream_metrics.time_scanning_total.start(); From b8dd95783fa6f8ac2c8470456b05a48bc868cd4f Mon Sep 17 00:00:00 2001 From: Ratul Dawar Date: Wed, 4 Mar 2026 21:37:05 +0530 Subject: [PATCH 2/2] Apply rustfmt in file_stream timer metric block --- datafusion/datasource/src/file_stream.rs | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/datafusion/datasource/src/file_stream.rs b/datafusion/datasource/src/file_stream.rs index 6f450f47df833..87e82d5314cfc 100644 --- a/datafusion/datasource/src/file_stream.rs +++ b/datafusion/datasource/src/file_stream.rs @@ -127,8 +127,11 @@ impl FileStream { // include time needed to start opening in `start_next_file` self.file_stream_metrics.time_opening.stop(); let next = { - let scanning_total_metric = - self.file_stream_metrics.time_scanning_total.metrics.clone(); + let scanning_total_metric = self + .file_stream_metrics + .time_scanning_total + .metrics + .clone(); let _timer = scanning_total_metric.timer(); self.start_next_file().transpose() };