Create Instance from Backup taken from a password enabled template not working

[abh1sar]

problem

Create Instance from Backup taken from a password enabled template shows the following error.

The Instance is created, but not accessible through password.

versions

4.22

The steps to reproduce the bug

1. Create a password enabled template
2. Create NAS backup from it
3. Create a new Instance from the Backup
4. It throws a error. Password is not shown and no passwords work.
   ...

What to do about it?

The UI should show the working password, which should be the same as the original instance

[github-actions]

This issue is stale because it has been open for 120 days with no activity. It may be removed by administrators of this project at any time. Remove the stale label or comment to request for removal of it to prevent this.

[weizhouapache]

I face the same issue when restore a backup

it works after I applied the workaround as below

 server/src/main/java/com/cloud/vm/UserVmManagerImpl.java | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/server/src/main/java/com/cloud/vm/UserVmManagerImpl.java b/server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
index 2308fbc8784..2292094869c 100644
--- a/server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
+++ b/server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
@@ -5847,6 +5847,9 @@ public class UserVmManagerImpl extends ManagerBase implements UserVmManager, Vir
         String reservationId = vmEntity.reserve(planner, plan, new ExcludeList(), Long.toString(callerUser.getId()));
         vmEntity.deploy(reservationId, Long.toString(callerUser.getId()), params, deployOnGivenHost);

+        if (params == null) {
+            params = new HashMap<>();
+        }
         Pair<UserVmVO, Map<VirtualMachineProfile.Param, Object>> vmParamPair = new Pair(vm, params);
         if (vm != null && vm.isUpdateParameters()) {
             // this value is not being sent to the backend; need only for api

cc @abh1sar @shwstppr