Skip to content

Restore Monaco find widget in Dag Code view#67391

Open
choo121600 wants to merge 2 commits into
apache:mainfrom
choo121600:fix/find-widget-in-codeview
Open

Restore Monaco find widget in Dag Code view#67391
choo121600 wants to merge 2 commits into
apache:mainfrom
choo121600:fix/find-widget-in-codeview

Conversation

@choo121600
Copy link
Copy Markdown
Member

Cmd/Ctrl+F in the Dag Code view opened the browser's native find bar instead of Monaco's find widget, and the widget icons rendered incorrectly in DEV_MODE=true.

Root cause

  • configureMonaco.ts imported only editor.api, which does not include
    the standalone find contribution or codicon font styles.
  • In DEV_MODE, Vite served font assets from :5173 while the page was
    served from :28080, causing font requests to resolve incorrectly and
    return HTML instead of TTF files.

Fix

  • Explicitly import findController and codiconStyles in
    configureMonaco.ts.
  • Set server.origin = "http://localhost:5173" in vite.config.ts so
    Vite emits correct asset URLs for cross-origin development setups.

Before

image

After

image

part of: #67359


Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

opus 4.7


  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@boring-cyborg boring-cyborg Bot added the area:UI Related to UI/UX. For Frontend Developers. label May 23, 2026
@choo121600 choo121600 linked an issue May 24, 2026 that may be closed by this pull request
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve dag code readability on Airflow UI

1 participant