Restore Monaco find widget in Dag Code view#67391
Open
choo121600 wants to merge 2 commits into
Open
Conversation
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cmd/Ctrl+F in the Dag Code view opened the browser's native find bar instead of Monaco's find widget, and the widget icons rendered incorrectly in
DEV_MODE=true.Root cause
configureMonaco.tsimported onlyeditor.api, which does not includethe standalone find contribution or codicon font styles.
DEV_MODE, Vite served font assets from:5173while the page wasserved from
:28080, causing font requests to resolve incorrectly andreturn HTML instead of TTF files.
Fix
findControllerandcodiconStylesinconfigureMonaco.ts.server.origin = "http://localhost:5173"invite.config.tssoVite emits correct asset URLs for cross-origin development setups.
Before
After
part of: #67359
Was generative AI tooling used to co-author this PR?
opus 4.7
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.