Skip to content

fix(providers/databricks): DatabricksWorkflowTaskGroup launch task now waits for upstream tasks#67369

Open
shubhgurav0590 wants to merge 1 commit into
apache:mainfrom
shubhgurav0590:fix/databricks-workflow-upstream-wait-51598
Open

fix(providers/databricks): DatabricksWorkflowTaskGroup launch task now waits for upstream tasks#67369
shubhgurav0590 wants to merge 1 commit into
apache:mainfrom
shubhgurav0590:fix/databricks-workflow-upstream-wait-51598

Conversation

@shubhgurav0590
Copy link
Copy Markdown

@shubhgurav0590 shubhgurav0590 commented May 23, 2026

Closes #51598

Problem

When using DatabricksWorkflowTaskGroup, the internal launch task
ignored upstream task dependencies and executed immediately at DAG
start, regardless of trigger_rule configuration.

Fix

Added create_databricks_workflow_task.set_upstream(root_task) in
the __exit__ method so the launch task correctly waits for all
upstream dependencies before executing.

Changes

  • One-line fix in databricks_workflow.py
  • Added unit test test_launch_task_waits_for_upstream_tasks
    validating that launch task correctly registers upstream task IDs

Testing

Unit test added in test_databricks_workflow.py covering the
external upstream dependency scenario from issue #51598.

Note on DAG Graph Screenshots

Previous PR #53559 was asked for before/after DAG graph screenshots.
Running into Windows/WSL encoding issues with Breeze setup.
Can provide screenshots if required during review — happy to
set up on a Linux environment if needed.

@boring-cyborg
Copy link
Copy Markdown

boring-cyborg Bot commented May 23, 2026

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example Dag that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@eladkal eladkal requested a review from jroachgolf84 May 24, 2026 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Airflow Databricks Operator Task Group Launch Task Not Properly Waiting for Upstream Tasks

1 participant