fix(providers/databricks): DatabricksWorkflowTaskGroup launch task now waits for upstream tasks#67369
Open
shubhgurav0590 wants to merge 1 commit into
Conversation
…w waits for upstream tasks
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #51598
Problem
When using DatabricksWorkflowTaskGroup, the internal launch task
ignored upstream task dependencies and executed immediately at DAG
start, regardless of trigger_rule configuration.
Fix
Added
create_databricks_workflow_task.set_upstream(root_task)inthe
__exit__method so the launch task correctly waits for allupstream dependencies before executing.
Changes
databricks_workflow.pytest_launch_task_waits_for_upstream_tasksvalidating that launch task correctly registers upstream task IDs
Testing
Unit test added in
test_databricks_workflow.pycovering theexternal upstream dependency scenario from issue #51598.
Note on DAG Graph Screenshots
Previous PR #53559 was asked for before/after DAG graph screenshots.
Running into Windows/WSL encoding issues with Breeze setup.
Can provide screenshots if required during review — happy to
set up on a Linux environment if needed.