Fix capped dashboard historical percentages#67366
Open
bobu-putheeckal wants to merge 1 commit into
Open
Conversation
bobu-putheeckal
requested review from
bbovenzi,
choo121600,
guan404ming,
pierrejeambrun,
ryanahamilton,
shubhamraj-git and
vatsrahul1001
as code owners
choo121600
reviewed
May 24, 2026
Comment on lines
-51
to
+54
| const statePercent = capped ? undefined : total === 0 ? 0 : ((runs / total) * 100).toFixed(2); | ||
| const statePercent = | ||
| showPercentages && !capped && total !== 0 ? ((runs / total) * 100).toFixed(2) : undefined; |
Member
There was a problem hiding this comment.
With the previous behavior, each row displayed 0% when all counts were 0, but after this changes it seems nothing will be shown instead.
Not blocking, but personally I think showing 0% is clearer than rendering nothing (undefined). WDYT?
Member
|
Also, for UI-related contributions, could you include before/after screenshots in the PR description? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When historical metric counts reach the API cap, the dashboard cannot compute a reliable total from the capped values. This hides percentages and proportional bars for the affected metric group while keeping capped counts such as
1000+visible.closes: #67336
Tests:
npx pnpm@10.24.0 test src/pages/Dashboard/HistoricalMetrics/DagRunMetrics.test.tsxnpx pnpm@10.24.0 lintgit diff --checkWas generative AI tooling used to co-author this PR?
Generated-by: Codex following the guidelines