move remaining three vtk calls to node pipeline

Author: LKasianAnsys

src/ansys/visor/viewer/renderer/local_renderer.py

@@ -160,46 +160,49 @@ def deregister_all(self) -> None:
     def apply_visibility(self, node_id: int, visible: bool) -> None:
         """See :meth:`IRenderer.apply_visibility`.
 
-        Mutates the actor itself, not its property.  An unknown *node_id*
-        is a logged no-op, never a raise.
+        Resolves the pipeline and delegates to
+        :meth:`VtkNodePipeline.set_visibility`.  An unknown *node_id* is a
+        logged no-op, never a raise.
         """
         pipe = self._pipelines.get(node_id)
         if pipe is None:
             logger.debug(
                 "apply_visibility: no pipeline for node %s; skipping.", node_id
             )
             return
-        pipe.actor.SetVisibility(1 if visible else 0)
+        pipe.set_visibility(visible)
 
     def apply_opacity(self, node_id: int, opacity: float) -> None:
         """See :meth:`IRenderer.apply_opacity`.
 
-        Mutates the actor's property.  An unknown *node_id* is a logged
-        no-op, never a raise.
+        Resolves the pipeline and delegates to
+        :meth:`VtkNodePipeline.set_opacity`.  An unknown *node_id* is a
+        logged no-op, never a raise.
         """
         pipe = self._pipelines.get(node_id)
         if pipe is None:
             logger.debug(
                 "apply_opacity: no pipeline for node %s; skipping.", node_id
             )
             return
-        pipe.actor.GetProperty().SetOpacity(opacity)
+        pipe.set_opacity(opacity)
 
     def apply_diffuse_color(
         self, node_id: int, r: float, g: float, b: float
     ) -> None:
         """See :meth:`IRenderer.apply_diffuse_color`.
 
-        Mutates the actor property's diffuse colour only.  An unknown
-        *node_id* is a logged no-op, never a raise.
+        Resolves the pipeline and delegates to
+        :meth:`VtkNodePipeline.set_diffuse_color`.  An unknown *node_id*
+        is a logged no-op, never a raise.
         """
         pipe = self._pipelines.get(node_id)
         if pipe is None:
             logger.debug(
                 "apply_diffuse_color: no pipeline for node %s; skipping.", node_id
             )
             return
-        pipe.actor.GetProperty().SetDiffuseColor(r, g, b)
+        pipe.set_diffuse_color(r, g, b)
 
     def apply_edge_visibility(self, node_id: int, edge_visible: bool) -> None:
         """No-op in Story 1.2. Phase 3 populates."""

src/ansys/visor/viewer/vtk/node_pipeline.py

@@ -127,6 +127,9 @@ def set_selected(self, selected: bool, diffuse_rgb: list[float]) -> None:
             The part's diffuse colour, re-applied unconditionally on both
             branches -- selection changes the ambient/diffuse lighting
             terms, it does not replace the part's colour.
+
+        Note: :meth:`set_diffuse_color` also writes ``SetDiffuseColor``;
+        this method is not a substitute for it and vice versa.
         """
         prop = self.actor.GetProperty()
         if selected:
@@ -138,6 +141,46 @@ def set_selected(self, selected: bool, diffuse_rgb: list[float]) -> None:
             prop.SetAmbient(0.0)
         prop.SetDiffuseColor(*diffuse_rgb)
 
+    def set_visibility(self, visible: bool) -> None:
+        """Show or hide this part.
+
+        Mutates the actor itself, not its property.
+
+        Parameters
+        ----------
+        visible:
+            Target state.  Absolute, never a toggle.
+        """
+        self.actor.SetVisibility(1 if visible else 0)
+
+    def set_opacity(self, opacity: float) -> None:
+        """Set this part's opacity.
+
+        Mutates the actor's property.
+
+        Parameters
+        ----------
+        opacity:
+            The opacity value to apply, passed through unchanged.
+        """
+        self.actor.GetProperty().SetOpacity(opacity)
+
+    def set_diffuse_color(self, r: float, g: float, b: float) -> None:
+        """Set this part's diffuse colour.
+
+        Mutates the actor property's diffuse colour only.
+
+        Parameters
+        ----------
+        r, g, b:
+            The diffuse colour components, passed through unchanged.
+
+        Note: :meth:`set_selected` also writes ``SetDiffuseColor`` on both
+        of its branches; this method is not a substitute for it and vice
+        versa.
+        """
+        self.actor.GetProperty().SetDiffuseColor(r, g, b)
+
     def set_color_variable(
         self,
         association: VisorVtkVariableType,