fix(opencode): prevent approved wildcard from overriding config deny rules#31541
Open
de-mh wants to merge 1 commit into
Open
fix(opencode): prevent approved wildcard from overriding config deny rules#31541de-mh wants to merge 1 commit into
de-mh wants to merge 1 commit into
Conversation
…rules
When a user clicks 'Allow always' for an edit, the approved list stores
{permission: 'edit', pattern: '*', action: 'allow'}. Because evaluate()
uses findLast across [...ruleset, ...approved], this broad allow always
wins over specific deny rules from the user config.
Fix: check config deny rules (ruleset-only evaluation) before checking
the combined ruleset+approved. Explicit deny in config is absolute and
cannot be overridden by runtime approvals.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #31540
Type of change
What does this PR do?
When a user clicks "Allow always" on an edit permission prompt,
always: ["*"]stores{permission: "edit", pattern: "*", action: "allow"}in the approved list.Permission.ask()callsevaluate(permission, pattern, ruleset, approved)which flattens to[...ruleset, ...approved]and usesfindLast— the approved wildcard always wins over config deny rules.Fix: evaluate config deny rules (ruleset-only) before the combined evaluation. If the config explicitly denies a pattern, DeniedError fires immediately regardless of runtime approvals.
How did you verify your code works?
bun typecheckcleanScreenshots / recordings
N/A — logic fix, no UI changes.
Checklist
If you do not follow this template your PR will be automatically rejected.