fix(plugin): prevent spinner garbage output in non-TTY environments#31529
Open
MD-Mushfiqur123 wants to merge 2 commits into
Open
fix(plugin): prevent spinner garbage output in non-TTY environments#31529MD-Mushfiqur123 wants to merge 2 commits into
MD-Mushfiqur123 wants to merge 2 commits into
Conversation
Fixes anomalyco#27908 When running 'opencode plugin install' from non-interactive shells (PowerShell, CI), spinner animation frames were printed as individual lines instead of being rendered in-place. Now checks process.stdout.isTTY before using animated spinner. In non-TTY environments, falls back to simple static text output.
github-actions
Bot
added
the
needs:compliance
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Potential duplicate PRs found:
All three PRs are addressing variations of the same core problem: spinner animation garbage output in non-TTY environments. You may want to check if these are already merged/closed or if there's overlap with the current PR #31529. |
github-actions
Bot
removed
the
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #27908
Type of change
What does this PR do?
When running
opencode plugin installfrom non-interactive shells (PowerShell, CI/CD), the spinner animation outputs garbage — each frame (◓, ◑, ◒, ◐) appears on a new line because carriage returns are not interpreted in non-TTY environments.The fix adds a
createNonTTYSpinner()function that outputs plain text (msg.../msg done) instead of animated escape sequences when stdout is not a TTY.How did you verify your code works?
npx tsc --noEmitpasses with no errorsprocess.stdout.isTTYchecks in the codebase (seepackages/opencode/src/cli/ui.ts:49)Checklist