fix: add 30s timeout to SQLite semaphore to prevent deadlock hangs#31461
Open
HrushiYadav wants to merge 1 commit into
Open
fix: add 30s timeout to SQLite semaphore to prevent deadlock hangs#31461HrushiYadav wants to merge 1 commit into
HrushiYadav wants to merge 1 commit into
Conversation
The in-process Semaphore(1) guarding the single SQLite connection has no timeout, so any deadlock or re-entrant lock attempt causes the process to hang forever with no error. Add a 30s timeout to both the regular query acquirer and the transaction acquirer so contention surfaces as a clear SqlError instead of a silent futex hang. Closes anomalyco#29395
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #29395
Type of change
What does this PR do?
The in-process
Semaphore(1)guarding the single SQLite connection insqlite.bun.tsblocks forever when the permit can't be acquired (deadlock, re-entrant lock, or concurrent instance contention). This adds a 30-secondEffect.timeoutFailto both the regular query acquirer and the transaction acquirer so the hang surfaces as a clearSqlErrorinstead of a silent futex wait with no timeout, no error, and no progress.How did you verify your code works?
InstanceStore.load->boot->fromDirectory->bootstrap.run) and confirmed both theacquirerandtransactionAcquirerare the only JS-level serialization points for SQLite accessEffect.timeoutFailcorrectly interacts withsemaphore.withPermits(timeout fires interruption, permit is not acquired, no leak)Effect.timeoutFailworks insideEffect.uninterruptibleMask+restore(...)(the restore region makessemaphore.takeinterruptible so the timeout signal can reach it)SqlErrorwithclassifySqliteErrormatches the existing error handling pathScreenshots / recordings
N/A (backend change)
Checklist