From 1d1705fe3ac3bc7c0d2fb7da3f014291a8070220 Mon Sep 17 00:00:00 2001 From: SkyZeroZx <73321943+SkyZeroZx@users.noreply.github.com> Date: Mon, 16 Nov 2026 00:29:57 -0500 Subject: [PATCH] fix(@angular/build): generate a separate server chunk for each prerendered page Server asset chunks were named after the page path with `.` and `/` replaced by `_`, so pages such as `blog/archive` and `blog_archive` shared one chunk and one of them was served in place of the other. Chunk paths now mirror the page path. Fixes #34722 --- .../src/utils/server-rendering/manifest.ts | 3 ++- .../utils/server-rendering/manifest_spec.ts | 26 +++++++++++++++++++ 2 files changed, 28 insertions(+), 1 deletion(-) diff --git a/packages/angular/build/src/utils/server-rendering/manifest.ts b/packages/angular/build/src/utils/server-rendering/manifest.ts index 6877107a0b96..b9d60f4edd1d 100644 --- a/packages/angular/build/src/utils/server-rendering/manifest.ts +++ b/packages/angular/build/src/utils/server-rendering/manifest.ts @@ -170,7 +170,8 @@ export async function generateAngularServerAppManifest( for (const file of [...additionalHtmlOutputFiles.values(), ...outputFiles]) { const extension = extname(file.path); if (extension === '.html') { - const jsChunkFilePath = `assets-chunks/${file.path.replace(/[./]/g, '_')}.mjs`; + // Mirror the asset path, which is unique, so that two assets never share a chunk. + const jsChunkFilePath = `assets-chunks/${file.path}.mjs`; const escapedContent = escapeUnsafeChars(file.text); serverAssetsChunks.push( diff --git a/packages/angular/build/src/utils/server-rendering/manifest_spec.ts b/packages/angular/build/src/utils/server-rendering/manifest_spec.ts index 4d9ae0da32f6..84701309eccb 100644 --- a/packages/angular/build/src/utils/server-rendering/manifest_spec.ts +++ b/packages/angular/build/src/utils/server-rendering/manifest_spec.ts @@ -192,6 +192,32 @@ describe('generateAngularServerAppManifest', () => { ); }); + it('should generate a separate chunk for each asset', async () => { + const { manifestContent, serverAssetsChunks } = await generateManifest({ + 'blog/archive/index.html': '
Archive
', + 'blog_archive/index.html': '
Landing
', + 'blog.archive/index.html': '
Release
', + }); + + expect(serverAssetsChunks).toEqual([ + jasmine.objectContaining({ + path: 'assets-chunks/blog/archive/index.html.mjs', + text: 'export default `
Archive
`;', + }), + jasmine.objectContaining({ + path: 'assets-chunks/blog_archive/index.html.mjs', + text: 'export default `
Landing
`;', + }), + jasmine.objectContaining({ + path: 'assets-chunks/blog.archive/index.html.mjs', + text: 'export default `
Release
`;', + }), + ]); + expect(manifestContent).toContain('import("./assets-chunks/blog/archive/index.html.mjs")'); + expect(manifestContent).toContain('import("./assets-chunks/blog_archive/index.html.mjs")'); + expect(manifestContent).toContain('import("./assets-chunks/blog.archive/index.html.mjs")'); + }); + it('should serialize a base href which contains JavaScript string delimiters', async () => { const { manifestContent } = await generateManifest( { 'index.html': '
' },