fixup! fix(@angular/ssr): settle writeResponseToNodeResponse when client disconnects

Author: alan-agius4

packages/angular/ssr/node/test/response_http1_spec.ts

@@ -109,11 +109,7 @@ describe('writeResponseToNodeResponse (HTTP/1.1)', () => {
   });
 
   it('should resolve and cancel reader when client disconnects while response is backpressured', async () => {
-    let resolveWritePromise: () => void;
-    const writePromise = new Promise<void>((resolve) => {
-      resolveWritePromise = resolve;
-    });
-
+    let writePromise!: Promise<void>;
     let readerCancelled = false;
     const largeChunk = 'x'.repeat(1024 * 1024 * 4); // 4MB to ensure backpressure
     const stream = new ReadableStream({
@@ -126,10 +122,8 @@ describe('writeResponseToNodeResponse (HTTP/1.1)', () => {
       },
     });
 
-    server.once('request', (req, nodeResponse) => {
-      void writeResponseToNodeResponse(new Response(stream), nodeResponse).finally(() => {
-        resolveWritePromise();
-      });
+    server.once('request', (_, nodeResponse) => {
+      writePromise = writeResponseToNodeResponse(new Response(stream), nodeResponse);
     });
 
     await new Promise<void>((resolve) => {

packages/angular/ssr/node/test/response_http2_spec.ts

@@ -118,11 +118,7 @@ describe('writeResponseToNodeResponse (HTTP/2)', () => {
   });
 
   it('should resolve and cancel reader when client disconnects while response is backpressured', async () => {
-    let resolveWritePromise: () => void;
-    const writePromise = new Promise<void>((resolve) => {
-      resolveWritePromise = resolve;
-    });
-
+    let writePromise!: Promise<void>;
     let readerCancelled = false;
     const largeChunk = 'x'.repeat(1024 * 1024); // 1MB to exceed HTTP/2 flow control window
     const stream = new ReadableStream({
@@ -135,10 +131,8 @@ describe('writeResponseToNodeResponse (HTTP/2)', () => {
       },
     });
 
-    server.once('request', (req, nodeResponse) => {
-      void writeResponseToNodeResponse(new Response(stream), nodeResponse).finally(() => {
-        resolveWritePromise();
-      });
+    server.once('request', (_, nodeResponse) => {
+      writePromise = writeResponseToNodeResponse(new Response(stream), nodeResponse);
     });
 
     await new Promise<void>((resolve) => {