fix(@angular/cli): improve error handling and test for skipped registry packages

Author: maruthang

packages/angular/cli/src/commands/update/schematic/index.ts

@@ -858,7 +858,7 @@ export default function (options: UpdateSchema): Rule {
           // If the package cannot be fetched (e.g. private registry, JSR, AWS CodeArtifact,
           // or local workspace packages), return a partial object so the reduce below can
           // decide whether to warn or hard-fail based on whether it was explicitly requested.
-          const message = error instanceof Error ? error.message : String(error);
+          const message = (error as { message?: string }).message ?? String(error);
           logger.warn(
             `Package '${depName}' could not be fetched from the registry: ${message}`,
           );

packages/angular/cli/src/commands/update/schematic/index_spec.ts

@@ -336,18 +336,19 @@ describe('@schematics/update', () => {
     expect(resultTreeContent.endsWith('}')).toBeTrue();
   });
 
-  it('skips packages that cannot be fetched from the registry and continues updating others', async () => {
+  it('continues updating others when one package fetch fails', async () => {
     // Regression test for https://github.com/angular/angular-cli/issues/28834
     // Packages from private registries, JSR, AWS CodeArtifact, or local workspaces
     // may resolve as npm-registry packages (pass isPkgFromRegistry) but fail to fetch
-    // with a 404.  The schematic should warn and skip them rather than hard-failing.
+    // with a 404.  The schematic should warn and skip them rather than hard-failing,
+    // and other explicitly-requested packages should still be updated.
     const inputTree = new UnitTestTree(
       new HostTree(
         new virtualFs.test.TestHost({
           '/package.json': JSON.stringify({
             name: 'blah',
             dependencies: {
-              // A real package that can be updated:
+              // A real package that should be updated:
               '@angular-devkit-tests/update-base': '1.0.0',
               // A scoped package that does not exist on the npm registry (simulates a
               // private / JSR / CodeArtifact package that passes the registry specifier
@@ -363,18 +364,22 @@ describe('@schematics/update', () => {
     schematicRunner.logger.subscribe((x) => messages.push(x.message));
 
     // Should NOT throw even though one package cannot be fetched.
-    const resultTree = await schematicRunner.runSchematic('update', undefined, inputTree);
+    const resultTree = await schematicRunner.runSchematic(
+      'update',
+      { packages: ['@angular-devkit-tests/update-base'] },
+      inputTree,
+    );
 
-    // The unfetchable package should be warned about.
+    // The unfetchable package should produce a warning.
     expect(
       messages.some((m) => m.includes('@private-nonexistent/package-ng-update-issue-28834')),
     ).toBeTrue();
 
-    // The package.json should be unchanged (nothing to update in no-packages mode).
+    // The valid package should have been updated despite the other package failing.
     const { dependencies } = resultTree.readJson('/package.json') as {
       dependencies: Record<string, string>;
     };
-    expect(dependencies['@angular-devkit-tests/update-base']).toBe('1.0.0');
+    expect(dependencies['@angular-devkit-tests/update-base']).toBe('1.1.0');
     expect(dependencies['@private-nonexistent/package-ng-update-issue-28834']).toBe('1.0.0');
   }, 45000);