fix(@angular/build): prevent build process hang on unhandled error (#33715)

When an unhandled exception is thrown during a build (such as IndexHtmlGenerator.readIndex throwing when an index HTML file is missing or unreadable), executeBuild() previously re-threw without calling .dispose() on executionResult or angularCompilationContext. Consequently, open ESBuild child processes, TypeScript compiler worker threads, and SQLite database connections prevented the Node.js process from exiting.

This commit addresses the issue by:
1. Wrapping the entire body of executeBuild() in a try...catch block and instantiating executionResult immediately after bundlerContexts is created, so any thrown error reliably disposes all worker pools and AST caches before re-throwing.
2. Closing the SQLite cache store (angular-i18n.db) in I18nInliner.close() alongside worker pool destruction.
3. Ensuring Sass workers are shut down in build-action even if an initial --watch build throws an exception.

Closes #33716

PR Close #33715

Author: alan-agius4

packages/angular/build/src/builders/application/build-action.ts

@@ -81,16 +81,16 @@ export async function* runEsBuildBuildAction(
   const withProgress: typeof withSpinner = progress ? withSpinner : withNoProgress;
 
   // Initial build
-  let result: ExecutionResult;
+  let result: ExecutionResult | undefined;
   try {
     // Perform the build action
     result = await withProgress('Building...', () => action());
 
     // Log all diagnostic (error/warning/logs) messages
     await logMessages(logger, result, colors, jsonLogs);
   } finally {
-    // Ensure Sass workers are shutdown if not watching
-    if (!watch) {
+    // Ensure Sass workers are shutdown if not watching or if the initial build failed
+    if (!watch || !result) {
       shutdownSassWorkerPool();
     }
   }