Repository navigation
Commit 9e061a2
committed
fix(@angular/build): fall back to Babel linker in WebContainer environments
PR #34540 declared `@oxc-parser/binding-wasm32-wasi` as an optional
dependency of `@angular/build` to avoid runtime package manager execution
inside WebContainer environments. However, upstream WASI bindings for
`oxc-parser` currently fail to initialize due to a version and ABI
incompatibility between `@napi-rs/wasm-runtime@1.2.6` and `@emnapi/core`
(napi-rs/napi-rs#3674). When initialization fails, `oxc-parser` falls back
to shelling out to `pnpm i` in `/tmp` from inside the Piscina worker thread,
which surfaces as a fatal `ERR_REQUIRE_CYCLE_MODULE` error and crashes
`ng serve` and `ng build`.
Furthermore, `oxc-transform` was eagerly imported at top-level in
`javascript-transformer-worker.ts`, causing worker evaluation to fail
immediately upon startup even when OXC was not needed.
This change resolves the issue in WebContainer environments:
1. Defaults `useBabelLinker` to `true` when running within WebContainer
(`process.versions.webcontainer`), mirroring `useSassEmbedded`.
2. Lazily imports `oxc-transform` in `javascript-transformer-worker.ts` so
it is never evaluated during worker module initialization.
3. Skips attempting OXC in WebContainer (unless explicitly requested via
`NG_BUILD_BABEL_LINKER=false`), and gracefully falls back to the pure-JS
Babel linker if OXC fails to load.
Fixes #345241 parent ef600f2 commit 9e061a2
4 files changed
Lines changed: 111 additions & 7 deletions
File tree
- packages/angular/build/src
- tools/javascript-transformer
- utils
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
22 | | - | |
23 | 22 | | |
24 | 23 | | |
25 | 24 | | |
| |||
54 | 53 | | |
55 | 54 | | |
56 | 55 | | |
| 56 | + | |
| 57 | + | |
57 | 58 | | |
58 | 59 | | |
59 | 60 | | |
| |||
181 | 182 | | |
182 | 183 | | |
183 | 184 | | |
184 | | - | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
185 | 197 | | |
186 | 198 | | |
187 | 199 | | |
| |||
222 | 234 | | |
223 | 235 | | |
224 | 236 | | |
225 | | - | |
226 | | - | |
| 237 | + | |
227 | 238 | | |
228 | 239 | | |
229 | 240 | | |
230 | 241 | | |
231 | 242 | | |
232 | | - | |
| 243 | + | |
233 | 244 | | |
234 | 245 | | |
235 | 246 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
343 | 343 | | |
344 | 344 | | |
345 | 345 | | |
| 346 | + | |
| 347 | + | |
| 348 | + | |
| 349 | + | |
| 350 | + | |
| 351 | + | |
| 352 | + | |
| 353 | + | |
| 354 | + | |
| 355 | + | |
| 356 | + | |
| 357 | + | |
| 358 | + | |
| 359 | + | |
| 360 | + | |
| 361 | + | |
| 362 | + | |
| 363 | + | |
| 364 | + | |
| 365 | + | |
| 366 | + | |
| 367 | + | |
| 368 | + | |
| 369 | + | |
| 370 | + | |
| 371 | + | |
| 372 | + | |
| 373 | + | |
| 374 | + | |
| 375 | + | |
| 376 | + | |
| 377 | + | |
| 378 | + | |
346 | 379 | | |
347 | 380 | | |
348 | 381 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
218 | 218 | | |
219 | 219 | | |
220 | 220 | | |
221 | | - | |
| 221 | + | |
| 222 | + | |
222 | 223 | | |
223 | 224 | | |
224 | 225 | | |
225 | | - | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
226 | 229 | | |
227 | 230 | | |
228 | 231 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
245 | 245 | | |
246 | 246 | | |
247 | 247 | | |
| 248 | + | |
| 249 | + | |
| 250 | + | |
| 251 | + | |
| 252 | + | |
| 253 | + | |
| 254 | + | |
| 255 | + | |
| 256 | + | |
| 257 | + | |
| 258 | + | |
| 259 | + | |
| 260 | + | |
| 261 | + | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
| 265 | + | |
| 266 | + | |
| 267 | + | |
| 268 | + | |
| 269 | + | |
| 270 | + | |
| 271 | + | |
| 272 | + | |
| 273 | + | |
| 274 | + | |
| 275 | + | |
| 276 | + | |
| 277 | + | |
| 278 | + | |
| 279 | + | |
| 280 | + | |
| 281 | + | |
| 282 | + | |
| 283 | + | |
| 284 | + | |
| 285 | + | |
| 286 | + | |
| 287 | + | |
| 288 | + | |
| 289 | + | |
| 290 | + | |
| 291 | + | |
| 292 | + | |
| 293 | + | |
| 294 | + | |
| 295 | + | |
| 296 | + | |
| 297 | + | |
| 298 | + | |
| 299 | + | |
| 300 | + | |
| 301 | + | |
| 302 | + | |
| 303 | + | |
| 304 | + | |
0 commit comments