Repository navigation
Commit 922ddfd
committed
fix(@angular/build): report the failing sequence sub-option in runner args errors
The `runnerArgs` validation reports every invalid value for the
`--sequence` option with a single message that only lists the supported
sub-option names: `--sequence.seed=-1` fails with 'The Vitest
"--sequence" option requires only the following options:
"--sequence.shuffle", "--sequence.seed".' although the user already
used one of those options, and nothing states the actual value
requirement.
Report each failing sub-option individually, matching the phrasing used
for top-level options: an unknown name such as `--sequence.concurrent`
is reported as not supported alongside the accepted names, and an
invalid value such as `--sequence.seed=-1` is reported with the
sub-option's own value requirement.
An invalid `--sequence.shuffle` value is not testable through the real
Vitest parser, which types the option as a boolean flag and treats a
provided value as a test file filter.1 parent 63a1c6a commit 922ddfd
2 files changed
Lines changed: 47 additions & 5 deletions
File tree
- packages/angular/build/src/builders/unit-test/runners/vitest
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
49 | 49 | | |
50 | 50 | | |
51 | 51 | | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
52 | 58 | | |
53 | 59 | | |
54 | 60 | | |
| |||
63 | 69 | | |
64 | 70 | | |
65 | 71 | | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
66 | 76 | | |
67 | 77 | | |
68 | 78 | | |
| |||
86 | 96 | | |
87 | 97 | | |
88 | 98 | | |
89 | | - | |
90 | | - | |
91 | | - | |
| 99 | + | |
92 | 100 | | |
93 | 101 | | |
94 | 102 | | |
95 | 103 | | |
96 | 104 | | |
97 | 105 | | |
98 | 106 | | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
99 | 129 | | |
100 | 130 | | |
101 | 131 | | |
| |||
264 | 294 | | |
265 | 295 | | |
266 | 296 | | |
267 | | - | |
| 297 | + | |
| 298 | + | |
| 299 | + | |
| 300 | + | |
| 301 | + | |
| 302 | + | |
268 | 303 | | |
269 | 304 | | |
270 | 305 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
122 | 122 | | |
123 | 123 | | |
124 | 124 | | |
125 | | - | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
126 | 133 | | |
127 | 134 | | |
128 | 135 | | |
| |||
0 commit comments