Skip to content

Commit 5ef8227

Browse files
committed
fixup! fix(@angular/cli): default ignoreScripts to true when install options are provided
1 parent 8848a2c commit 5ef8227

1 file changed

Lines changed: 36 additions & 0 deletions

File tree

‎packages/angular/cli/src/package-managers/package-manager_spec.ts‎

Lines changed: 36 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -154,6 +154,42 @@ describe('PackageManager', () => {
154154
});
155155

156156
describe('acquireTempPackage', () => {
157+
it('should pass ignoreScriptsFlag by default when no options are provided', async () => {
158+
const testHost = new MockHost({ '/tmp/project/node_modules': true });
159+
const pm = new PackageManager(testHost, '/tmp/project', descriptor);
160+
spyOn(testHost, 'createTempDirectory').and.resolveTo(
161+
'/tmp/project/node_modules/angular-cli-tmp-packages-abc',
162+
);
163+
spyOn(testHost, 'writeFile').and.resolveTo();
164+
spyOn(testHost, 'runCommand').and.resolveTo({ stdout: '', stderr: '' });
165+
166+
await pm.acquireTempPackage('foo@1.0.0');
167+
168+
expect(testHost.runCommand).toHaveBeenCalledWith(
169+
descriptor.binary,
170+
[descriptor.addCommand, 'foo@1.0.0', descriptor.ignoreScriptsFlag],
171+
jasmine.any(Object),
172+
);
173+
});
174+
175+
it('should not pass ignoreScriptsFlag when ignoreScripts is explicitly false', async () => {
176+
const testHost = new MockHost({ '/tmp/project/node_modules': true });
177+
const pm = new PackageManager(testHost, '/tmp/project', descriptor);
178+
spyOn(testHost, 'createTempDirectory').and.resolveTo(
179+
'/tmp/project/node_modules/angular-cli-tmp-packages-abc',
180+
);
181+
spyOn(testHost, 'writeFile').and.resolveTo();
182+
spyOn(testHost, 'runCommand').and.resolveTo({ stdout: '', stderr: '' });
183+
184+
await pm.acquireTempPackage('foo@1.0.0', { ignoreScripts: false });
185+
186+
expect(testHost.runCommand).toHaveBeenCalledWith(
187+
descriptor.binary,
188+
[descriptor.addCommand, 'foo@1.0.0'],
189+
jasmine.any(Object),
190+
);
191+
});
192+
157193
it('should copy and sanitize pnpm-workspace.yaml when package manager is pnpm and workspace file exists', async () => {
158194
const pnpmDescriptor = SUPPORTED_PACKAGE_MANAGERS['pnpm'];
159195
const testHost = new MockHost({ '/tmp/project/node_modules': true });

0 commit comments

Comments
 (0)