fix(@angular/cli): discover migrations from installed packages when omitted by registry metadata (#33718)

Private package registries such as GitHub Packages frequently strip out custom non-npm metadata properties (e.g., ng-update or schematics) from their remote API responses. Previously, this caused ng update to skip migration execution during updates from those registries, even though ng update --migrate-only worked correctly.

This commit adds a post-installation disk-fallback check in ng update: for any updated packages that were not scheduled for migrations from registry metadata, the CLI inspects node_modules/<package>/package.json on disk after installation. If an ng-update.migrations collection is found, it is automatically added to the migration queue and executed.

Closes #33717

PR Close #33718

Author: alan-agius4

packages/angular/cli/src/commands/update/cli.ts

@@ -634,7 +634,7 @@ export default class UpdateCommandModule extends CommandModule<UpdateCommandArgs
       }
     }
 
-    const migrations = plan.migrationsToRun;
+    const migrations = await resolveFallbackMigrations(this.context.root, plan);
 
     if (migrations) {
       for (const migration of migrations) {
@@ -706,3 +706,49 @@ async function readPackageManifest(manifestPath: string): Promise<PackageManifes
     return undefined;
   }
 }
+
+/**
+ * Resolves migrations from installed package manifests on disk when they were omitted
+ * from the initial update plan.
+ *
+ * This fallback is necessary because private package registries (such as GitHub Packages)
+ * frequently strip custom non-npm metadata properties (like `ng-update`) from their remote
+ * registry API responses. By inspecting `node_modules/<package>/package.json` after installation,
+ * we ensure that any migration collections defined by the package are discovered and queued.
+ */
+export async function resolveFallbackMigrations(
+  workspaceRoot: string,
+  plan: UpdatePlan,
+): Promise<{ package: string; collection: string; from: string; to: string }[]> {
+  const migrations = [...plan.migrationsToRun];
+  const existingMigrationPackages = new Set(migrations.map((m) => m.package));
+
+  for (const [packageName, targetVersion] of plan.packagesToUpdate) {
+    if (existingMigrationPackages.has(packageName)) {
+      continue;
+    }
+
+    const packageJsonPath = findPackageJson(workspaceRoot, packageName);
+    if (packageJsonPath) {
+      try {
+        const packageJson = JSON.parse(await fs.readFile(packageJsonPath, 'utf8'));
+        const ngUpdate = packageJson?.['ng-update'];
+        if (ngUpdate && typeof ngUpdate === 'object' && typeof ngUpdate.migrations === 'string') {
+          const installedVersion = plan.packageInfoMap.get(packageName)?.installed.version;
+          if (installedVersion) {
+            migrations.push({
+              package: packageName,
+              collection: ngUpdate.migrations,
+              from: installedVersion,
+              to: targetVersion,
+            });
+          }
+        }
+      } catch {
+        // Ignore read/parse errors for optional fallback
+      }
+    }
+  }
+
+  return migrations;
+}

packages/angular/cli/src/commands/update/cli_spec.ts

@@ -0,0 +1,133 @@
+/**
+ * @license
+ * Copyright Google LLC All Rights Reserved.
+ *
+ * Use of this source code is governed by an MIT-style license that can be
+ * found in the LICENSE file at https://angular.dev/license
+ */
+
+import assert from 'node:assert';
+import { mkdir, mkdtemp, rm, writeFile } from 'node:fs/promises';
+import path from 'path';
+import { resolveFallbackMigrations } from './cli';
+import type { PackageVersionInfo, UpdatePlan } from './update-resolver';
+
+describe('resolveFallbackMigrations', () => {
+  let tempRoot: string;
+  let pkgDir: string;
+  beforeEach(async () => {
+    const baseTmpDir = process.env['TEST_TMPDIR'];
+    assert(baseTmpDir, 'TEST_TMPDIR is not set');
+    tempRoot = await mkdtemp(path.join(baseTmpDir, 'angular-cli-update-cli-test-'));
+    pkgDir = path.join(tempRoot, 'node_modules/@company/library-name');
+    await mkdir(pkgDir, { recursive: true });
+  });
+
+  afterEach(async () => {
+    await rm(tempRoot, { recursive: true, force: true });
+  });
+
+  it('discovers migrations from installed package.json when omitted from plan.migrationsToRun', async () => {
+    await writeFile(
+      path.join(pkgDir, 'package.json'),
+      JSON.stringify({
+        name: '@company/library-name',
+        version: '21.2.0-next.1',
+        'ng-update': {
+          migrations: './schematics/migration.json',
+        },
+      }),
+      'utf8',
+    );
+
+    const plan: UpdatePlan = {
+      packagesToUpdate: new Map([['@company/library-name', '21.2.0-next.1']]),
+      migrationsToRun: [],
+      packageInfoMap: new Map([
+        [
+          '@company/library-name',
+          {
+            name: '@company/library-name',
+            npmPackageJson: {
+              name: '@company/library-name',
+              versions: ['21.1.0', '21.2.0-next.1'],
+              'dist-tags': {},
+            },
+            installed: {
+              version: '21.1.0' as unknown as PackageVersionInfo['version'],
+              packageJson: { name: '@company/library-name', version: '21.1.0' },
+              updateMetadata: { packageGroup: {}, requirements: {} },
+            },
+            packageJsonRange: '^21.1.0',
+          },
+        ],
+      ]),
+      registryClient: undefined as unknown as UpdatePlan['registryClient'],
+    };
+
+    const migrations = await resolveFallbackMigrations(tempRoot, plan);
+
+    expect(migrations).toEqual([
+      {
+        package: '@company/library-name',
+        collection: './schematics/migration.json',
+        from: '21.1.0',
+        to: '21.2.0-next.1',
+      },
+    ]);
+  });
+
+  it('does not duplicate migration if package is already in plan.migrationsToRun', async () => {
+    await writeFile(
+      path.join(pkgDir, 'package.json'),
+      JSON.stringify({
+        name: '@company/library-name',
+        version: '21.2.0-next.1',
+        'ng-update': {
+          migrations: './schematics/migration.json',
+        },
+      }),
+      'utf8',
+    );
+
+    const plan: UpdatePlan = {
+      packagesToUpdate: new Map([['@company/library-name', '21.2.0-next.1']]),
+      migrationsToRun: [
+        {
+          package: '@company/library-name',
+          collection: './schematics/migration.json',
+          from: '21.1.0',
+          to: '21.2.0-next.1',
+        },
+      ],
+      packageInfoMap: new Map(),
+      registryClient: undefined as unknown as UpdatePlan['registryClient'],
+    };
+
+    const migrations = await resolveFallbackMigrations(tempRoot, plan);
+
+    expect(migrations).toHaveSize(1);
+  });
+
+  it('returns unchanged migrations when package has no ng-update field on disk', async () => {
+    await writeFile(
+      path.join(pkgDir, 'package.json'),
+      JSON.stringify({
+        name: '@company/library-name',
+        version: '21.2.0-next.1',
+      }),
+      'utf8',
+    );
+
+    const plan: UpdatePlan = {
+      packagesToUpdate: new Map([['@company/library-name', '21.2.0-next.1']]),
+      migrationsToRun: [],
+      packageInfoMap: new Map(),
+      registryClient: undefined as unknown as UpdatePlan['registryClient'],
+    };
+
+    const migrations = await resolveFallbackMigrations(tempRoot, plan);
+
+    expect(migrations).toHaveSize(0);
+  });
+});