Bug Description
ClickHouse parametric aggregates lose their params group when the AST is
rendered back to SQL: quantileTDigest(0.95)(value) becomes
quantileTDigest(value).
Root cause
FunctionCall has a Parameters field (added for ClickHouse fn(params)(args),
issue #482 / PR #487), but FunctionCall.SQL() (pkg/sql/ast/sql.go) renders
only Arguments and never emits Parameters.
To Reproduce
tree, _ := gosqlx.ParseWithDialect(
"SELECT quantileTDigest(0.95)(value) FROM events",
keywords.DialectClickHouse)
fmt.Println(tree.SQL())
// SELECT quantileTDigest(value) FROM events (0.95 lost!)
Expected Behavior
SELECT quantileTDigest(0.95)(value) FROM events
Notes
Exists in v1.14.0 and current main. PR: #529.
Bug Description
ClickHouse parametric aggregates lose their params group when the AST is
rendered back to SQL:
quantileTDigest(0.95)(value)becomesquantileTDigest(value).Root cause
FunctionCallhas aParametersfield (added for ClickHousefn(params)(args),issue #482 / PR #487), but
FunctionCall.SQL()(pkg/sql/ast/sql.go) rendersonly
Argumentsand never emitsParameters.To Reproduce
Expected Behavior
SELECT quantileTDigest(0.95)(value) FROM eventsNotes
Exists in v1.14.0 and current
main. PR: #529.