From dc477a93d1fd8e9dc5dd127da28a0429b9335ad4 Mon Sep 17 00:00:00 2001 From: Sanchit Date: Mon, 16 Nov 2026 06:07:18 +0000 Subject: [PATCH] fix(views): return empty fixed-package details for unknown purls The affected-by-advisories v2 page crashed with AttributeError when the requested purl has no matching package in the database: for_purl().first() returns None and get_fixed_package_details() dereferenced it. Return an empty mapping for a missing package so the page renders zero results instead of a 500. Add a regression test covering an unknown purl. Signed-off-by: Sanchit --- vulnerabilities/tests/test_view.py | 15 +++++++++++++++ vulnerabilities/views.py | 3 +++ 2 files changed, 18 insertions(+) diff --git a/vulnerabilities/tests/test_view.py b/vulnerabilities/tests/test_view.py index bcee104ac..5d220200c 100644 --- a/vulnerabilities/tests/test_view.py +++ b/vulnerabilities/tests/test_view.py @@ -379,3 +379,18 @@ def test_throttle_after_15_requests(self): HTTP_USER_AGENT="test-agent", ) assert response.status_code == 429 + + +class AffectedByAdvisoriesListViewTestCase(TestCase): + def setUp(self): + self.client = Client() + session = self.client.session + session["altcha_verified_at"] = time.time() + session.save() + cache.clear() + + def test_unknown_purl_returns_empty_results(self): + response = self.client.get("/affected-by-advisories/v2/pkg:pypi/nonexistent-pkg@9.9.9") + assert response.status_code == 200 + assert response.context["fixed_package_details"] == {} + assert list(response.context["page_obj"]) == [] diff --git a/vulnerabilities/views.py b/vulnerabilities/views.py index b5ba74214..7ed1a2d89 100644 --- a/vulnerabilities/views.py +++ b/vulnerabilities/views.py @@ -438,6 +438,9 @@ def get_object(self, queryset=None): def get_fixed_package_details(package): + if package is None: + return defaultdict(list) + rows = package.affected_in_impacts.values_list( "advisory__avid", "fixed_by_packages",