From fec0ced25e04d7b6cc71d3588b9529a506f047a5 Mon Sep 17 00:00:00 2001 From: Aswin Gopal Date: Wed, 3 Jun 2026 13:16:21 +0530 Subject: [PATCH 1/3] Clarify InputBinding.Matches mask semantics --- .../InputSystem/Runtime/Actions/InputBinding.cs | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/Packages/com.unity.inputsystem/InputSystem/Runtime/Actions/InputBinding.cs b/Packages/com.unity.inputsystem/InputSystem/Runtime/Actions/InputBinding.cs index 45b4c3806c..e7a4230ac7 100644 --- a/Packages/com.unity.inputsystem/InputSystem/Runtime/Actions/InputBinding.cs +++ b/Packages/com.unity.inputsystem/InputSystem/Runtime/Actions/InputBinding.cs @@ -779,6 +779,12 @@ internal bool TriggersAction(InputAction action) /// /// Note that all comparisons are case-insensitive. /// + /// This method does not test bindings for equality. A binding may not match itself if one of + /// its mask properties contains a value that does not match as a filter. For example, a binding + /// with set to an empty string has a group filter but no non-empty group + /// to match against. To compare bindings for equivalence, use + /// or . + /// /// /// /// // Create a couple bindings which we can test against. @@ -837,6 +843,7 @@ internal bool TriggersAction(InputAction action) /// /// /// + /// public bool Matches(InputBinding binding) { return Matches(ref binding); From 8fb73dd1e6e39aa5f6592b49015659e8b4e7a5b7 Mon Sep 17 00:00:00 2001 From: AswinRajGopal <68984963+AswinRajGopal@users.noreply.github.com> Date: Wed, 3 Jun 2026 18:25:58 +0530 Subject: [PATCH 2/3] Update Packages/com.unity.inputsystem/InputSystem/Runtime/Actions/InputBinding.cs Co-authored-by: Sue Arkin <85237015+suearkinunity@users.noreply.github.com> --- .../InputSystem/Runtime/Actions/InputBinding.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Packages/com.unity.inputsystem/InputSystem/Runtime/Actions/InputBinding.cs b/Packages/com.unity.inputsystem/InputSystem/Runtime/Actions/InputBinding.cs index e7a4230ac7..9b6a7de5b2 100644 --- a/Packages/com.unity.inputsystem/InputSystem/Runtime/Actions/InputBinding.cs +++ b/Packages/com.unity.inputsystem/InputSystem/Runtime/Actions/InputBinding.cs @@ -779,7 +779,7 @@ internal bool TriggersAction(InputAction action) /// /// Note that all comparisons are case-insensitive. /// - /// This method does not test bindings for equality. A binding may not match itself if one of + /// This method doesn't test bindings for equality. A binding may not match itself if one of /// its mask properties contains a value that does not match as a filter. For example, a binding /// with set to an empty string has a group filter but no non-empty group /// to match against. To compare bindings for equivalence, use From c863ddffdb6b62c500ce977a2b2f743bb1b0a78f Mon Sep 17 00:00:00 2001 From: AswinRajGopal <68984963+AswinRajGopal@users.noreply.github.com> Date: Wed, 3 Jun 2026 18:26:07 +0530 Subject: [PATCH 3/3] Update Packages/com.unity.inputsystem/InputSystem/Runtime/Actions/InputBinding.cs Co-authored-by: Sue Arkin <85237015+suearkinunity@users.noreply.github.com> --- .../InputSystem/Runtime/Actions/InputBinding.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Packages/com.unity.inputsystem/InputSystem/Runtime/Actions/InputBinding.cs b/Packages/com.unity.inputsystem/InputSystem/Runtime/Actions/InputBinding.cs index 9b6a7de5b2..360ad1a646 100644 --- a/Packages/com.unity.inputsystem/InputSystem/Runtime/Actions/InputBinding.cs +++ b/Packages/com.unity.inputsystem/InputSystem/Runtime/Actions/InputBinding.cs @@ -780,7 +780,7 @@ internal bool TriggersAction(InputAction action) /// Note that all comparisons are case-insensitive. /// /// This method doesn't test bindings for equality. A binding may not match itself if one of - /// its mask properties contains a value that does not match as a filter. For example, a binding + /// its mask properties contains a value that doesn't match as a filter. For example, a binding /// with set to an empty string has a group filter but no non-empty group /// to match against. To compare bindings for equivalence, use /// or .